You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/20 21:22:05 UTC
[GitHub] [airflow] RosterIn opened a new issue #8937: change from zdesk to zenpy in ZendeskHook
RosterIn opened a new issue #8937:
URL: https://github.com/apache/airflow/issues/8937
**Description**
[zdesk ](https://github.com/fprimex/zdesk) hasn't been updated in two years.
there is a better maintained package [zenpy](https://github.com/facetoe/zenpy)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on issue #8937: change from zdesk to zenpy in ZendeskHook
Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on issue #8937:
URL: https://github.com/apache/airflow/issues/8937#issuecomment-1027312280
Hello @eladkal
I didn't start yet, I wanted to close this one first https://github.com/apache/airflow/pull/20386 but it's taking a little longer than expected. I think it's ready now and I can start working on this one :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #8937: change from zdesk to zenpy in ZendeskHook
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #8937:
URL: https://github.com/apache/airflow/issues/8937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bhaveshpatel640 commented on issue #8937: change from zdesk to zenpy in ZendeskHook
Posted by GitBox <gi...@apache.org>.
bhaveshpatel640 commented on issue #8937:
URL: https://github.com/apache/airflow/issues/8937#issuecomment-698883533
@eladkal @potiuk I will give it a shot, Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #8937: change from zdesk to zenpy in ZendeskHook
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #8937:
URL: https://github.com/apache/airflow/issues/8937#issuecomment-705820741
Yes I agree, let's use zenpy since zdesk seems to be abandoned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bhaveshpatel640 commented on issue #8937: change from zdesk to zenpy in ZendeskHook
Posted by GitBox <gi...@apache.org>.
bhaveshpatel640 commented on issue #8937:
URL: https://github.com/apache/airflow/issues/8937#issuecomment-698883533
@eladkal @potiuk I will give it a shot, Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] thelderop commented on issue #8937: change from zdesk to zenpy in ZendeskHook
Posted by GitBox <gi...@apache.org>.
thelderop commented on issue #8937:
URL: https://github.com/apache/airflow/issues/8937#issuecomment-724906077
I'll give this a shot!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xrmx commented on issue #8937: change from zdesk to zenpy in ZendeskHook
Posted by GitBox <gi...@apache.org>.
xrmx commented on issue #8937:
URL: https://github.com/apache/airflow/issues/8937#issuecomment-723657533
@eladkal nope
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn commented on issue #8937: change from zdesk to zenpy in ZendeskHook
Posted by GitBox <gi...@apache.org>.
RosterIn commented on issue #8937:
URL: https://github.com/apache/airflow/issues/8937#issuecomment-705750222
@xrmx Since the old package isn't maintained and can't have new functionality I think this change is required even if breaking change. Also Airflow soon change major version which is great because it will be able to introduce breaking changes.
I think better to hear from the project owners @potiuk @kaxil @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on issue #8937: change from zdesk to zenpy in ZendeskHook
Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on issue #8937:
URL: https://github.com/apache/airflow/issues/8937#issuecomment-999529426
Hi,
I can work on this one :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xrmx commented on issue #8937: change from zdesk to zenpy in ZendeskHook
Posted by GitBox <gi...@apache.org>.
xrmx commented on issue #8937:
URL: https://github.com/apache/airflow/issues/8937#issuecomment-704467864
Looking at the zenpy code it looks like that every endpoint is wrapped in a class, see https://github.com/facetoe/zenpy/blob/master/zenpy/__init__.py#L97. Can't see a sane way to map the plain path to a class to keep backwards compatibility. Said that we can leverage the `BaseApi` class in https://github.com/facetoe/zenpy/blob/master/zenpy/lib/api.py to get ratelimit handling for free. Do you have any thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bhaveshpatel640 removed a comment on issue #8937: change from zdesk to zenpy in ZendeskHook
Posted by GitBox <gi...@apache.org>.
bhaveshpatel640 removed a comment on issue #8937:
URL: https://github.com/apache/airflow/issues/8937#issuecomment-698883533
@eladkal @potiuk I will give it a shot, Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #8937: change from zdesk to zenpy in ZendeskHook
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #8937:
URL: https://github.com/apache/airflow/issues/8937#issuecomment-725072046
I assigned you to this ticket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #8937: change from zdesk to zenpy in ZendeskHook
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #8937:
URL: https://github.com/apache/airflow/issues/8937#issuecomment-723593932
@xrmx do you want to work on this task?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #8937: change from zdesk to zenpy in ZendeskHook
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #8937:
URL: https://github.com/apache/airflow/issues/8937#issuecomment-705820741
Yes I agree, let's use zenpy since zdesk seems to be abandoned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn commented on issue #8937: change from zdesk to zenpy in ZendeskHook
Posted by GitBox <gi...@apache.org>.
RosterIn commented on issue #8937:
URL: https://github.com/apache/airflow/issues/8937#issuecomment-705750222
@xrmx Since the old package isn't maintained and can't have new functionality I think this change is required even if breaking change. Also Airflow soon change major version which is great because it will be able to introduce breaking changes.
I think better to hear from the project owners @potiuk @kaxil @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #8937: change from zdesk to zenpy in ZendeskHook
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #8937:
URL: https://github.com/apache/airflow/issues/8937#issuecomment-1026242281
@pierrejeambrun are you still working on this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #8937: change from zdesk to zenpy in ZendeskHook
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #8937:
URL: https://github.com/apache/airflow/issues/8937#issuecomment-999560902
Go ahead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org