You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/03 09:48:57 UTC

[GitHub] [airflow] tirkarthi commented on a diff in pull request #27428: Handle exception during serializing incompatible executor_config object.

tirkarthi commented on code in PR #27428:
URL: https://github.com/apache/airflow/pull/27428#discussion_r1012685477


##########
airflow/api_connexion/schemas/task_instance_schema.py:
##########
@@ -33,6 +33,14 @@
 from airflow.utils.state import State
 
 
+class _ExecutorConfigField(fields.String):
+    def _serialize(self, value, attr, obj, **kwargs):
+        try:
+            return super()._serialize(value, attr, obj, **kwargs)
+        except Exception:

Review Comment:
   The `executor_config` in case of kubernetes can have values serialized and stored in one version to be picked up later by another kubernetes version in case of Airflow upgrade with old task instances. We noticed `AttributeError` in our case as per the issue but if the serialization fails due to other cases we just want to return `{}` so that other task instances are not affected. There could be other exceptions here as well. PR is similar to https://github.com/apache/airflow/pull/24117



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org