You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@daffodil.apache.org by GitBox <gi...@apache.org> on 2019/06/06 20:06:01 UTC
[GitHub] [incubator-daffodil] codecov-io commented on issue #218: Implement
dfdl:choiceLength='explicit'
codecov-io commented on issue #218: Implement dfdl:choiceLength='explicit'
URL: https://github.com/apache/incubator-daffodil/pull/218#issuecomment-499647012
# [Codecov](https://codecov.io/gh/apache/incubator-daffodil/pull/218?src=pr&el=h1) Report
> Merging [#218](https://codecov.io/gh/apache/incubator-daffodil/pull/218?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-daffodil/commit/53d6b4f342140f9a807ee1ca087dbeaf0367ade7?src=pr&el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `82.95%`.
[](https://codecov.io/gh/apache/incubator-daffodil/pull/218?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
+ Coverage 79.81% 79.96% +0.14%
==========================================
Files 388 389 +1
Lines 22766 22840 +74
Branches 2641 2609 -32
==========================================
+ Hits 18170 18263 +93
+ Misses 4596 4577 -19
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-daffodil/pull/218?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rg/apache/daffodil/processors/parsers/Parser.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/218/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtcnVudGltZTEvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9kYWZmb2RpbC9wcm9jZXNzb3JzL3BhcnNlcnMvUGFyc2VyLnNjYWxh) | `78.57% <ø> (ø)` | :arrow_up: |
| [...cala/org/apache/daffodil/io/DataOutputStream.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/218/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtaW8vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9kYWZmb2RpbC9pby9EYXRhT3V0cHV0U3RyZWFtLnNjYWxh) | `0% <ø> (ø)` | :arrow_up: |
| [...ala/org/apache/daffodil/processors/EvElement.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/218/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtcnVudGltZTEvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9kYWZmb2RpbC9wcm9jZXNzb3JzL0V2RWxlbWVudC5zY2FsYQ==) | `94.87% <ø> (ø)` | :arrow_up: |
| [...g/apache/daffodil/grammar/ChoiceGrammarMixin.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/218/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtY29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2RhZmZvZGlsL2dyYW1tYXIvQ2hvaWNlR3JhbW1hck1peGluLnNjYWxh) | `100% <ø> (ø)` | :arrow_up: |
| [...g/apache/daffodil/dsom/RuntimePropertyMixins.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/218/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtY29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2RhZmZvZGlsL2Rzb20vUnVudGltZVByb3BlcnR5TWl4aW5zLnNjYWxh) | `93.22% <ø> (ø)` | :arrow_up: |
| [...rocessors/unparsers/SpecifiedLengthUnparsers.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/218/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtcnVudGltZTEtdW5wYXJzZXIvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9kYWZmb2RpbC9wcm9jZXNzb3JzL3VucGFyc2Vycy9TcGVjaWZpZWRMZW5ndGhVbnBhcnNlcnMuc2NhbGE=) | `84.09% <ø> (ø)` | :arrow_up: |
| [...n/scala/org/apache/daffodil/dsom/ChoiceGroup.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/218/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtY29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2RhZmZvZGlsL2Rzb20vQ2hvaWNlR3JvdXAuc2NhbGE=) | `75% <ø> (ø)` | :arrow_up: |
| [...l/dsom/RawCommonRuntimeValuedPropertiesMixin.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/218/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtY29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2RhZmZvZGlsL2Rzb20vUmF3Q29tbW9uUnVudGltZVZhbHVlZFByb3BlcnRpZXNNaXhpbi5zY2FsYQ==) | `79.62% <0%> (-3.07%)` | :arrow_down: |
| [...sors/unparsers/SuppressableSeparatorUnparser.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/218/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtcnVudGltZTEtdW5wYXJzZXIvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9kYWZmb2RpbC9wcm9jZXNzb3JzL3VucGFyc2Vycy9TdXBwcmVzc2FibGVTZXBhcmF0b3JVbnBhcnNlci5zY2FsYQ==) | `95.91% <100%> (-1.19%)` | :arrow_down: |
| [...daffodil/grammar/primitives/ChoiceCombinator.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/218/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtY29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2RhZmZvZGlsL2dyYW1tYXIvcHJpbWl0aXZlcy9DaG9pY2VDb21iaW5hdG9yLnNjYWxh) | `85.05% <100%> (+0.91%)` | :arrow_up: |
| ... and [42 more](https://codecov.io/gh/apache/incubator-daffodil/pull/218/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-daffodil/pull/218?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-daffodil/pull/218?src=pr&el=footer). Last update [53d6b4f...ff91e26](https://codecov.io/gh/apache/incubator-daffodil/pull/218?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services