You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "pgier (via GitHub)" <gi...@apache.org> on 2023/05/05 16:22:42 UTC

[GitHub] [pulsar] pgier opened a new issue, #20231: [Bug] Prevent topic names with quotes and other special characters

pgier opened a new issue, #20231:
URL: https://github.com/apache/pulsar/issues/20231

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
   
   
   ### Version
   
   2.11
   
   ### Minimal reproduce step
   
   Install Pulsar and create a topic with a double quote in the name.
   
   ### What did you expect to see?
   
   I would expect this to be prevented with an error
   
   ### What did you see instead?
   
   The topic is created
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] pgier commented on issue #20231: [Bug] Prevent topic names with quotes and other special characters

Posted by "pgier (via GitHub)" <gi...@apache.org>.
pgier commented on issue #20231:
URL: https://github.com/apache/pulsar/issues/20231#issuecomment-1536632131

   Closing this as it seems it will be addressed in #19239


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] MMirelli commented on issue #20231: [Bug] Prevent topic names with quotes and other special characters

Posted by "MMirelli (via GitHub)" <gi...@apache.org>.
MMirelli commented on issue #20231:
URL: https://github.com/apache/pulsar/issues/20231#issuecomment-1556293485

   I'd like to pick this up. My plan is to implement the logic behind https://github.com/apache/pulsar/pull/19582, while keeping the default for `strictTopicNameEnabled` set to `false` not to break compatibility.
   
   I will probably add the feature to: https://github.com/apache/pulsar/blob/75d58fda2fe99471abddc60f7ed671aaa6073e66/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java#L232.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on issue #20231: [Bug] Prevent topic names with quotes and other special characters

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #20231:
URL: https://github.com/apache/pulsar/issues/20231#issuecomment-1599954840

   The issue had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug] Prevent topic names with quotes and other special characters [pulsar]

Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat closed issue #20231: [Bug] Prevent topic names with quotes and other special characters
URL: https://github.com/apache/pulsar/issues/20231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] pgier commented on issue #20231: [Bug] Prevent topic names with quotes and other special characters

Posted by "pgier (via GitHub)" <gi...@apache.org>.
pgier commented on issue #20231:
URL: https://github.com/apache/pulsar/issues/20231#issuecomment-1536493742

   Related to #20230 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug] Prevent topic names with quotes and other special characters [pulsar]

Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat commented on issue #20231:
URL: https://github.com/apache/pulsar/issues/20231#issuecomment-6386648461

   Thanks @pgier for the report. This was reported on Pulsar 2.11, which is no longer supported; the supported releases are 4.0.x, 4.2.x and 5.0.x. Much of the code involved has changed since, and the problem hasn't been confirmed on a current release, so I'm closing it as part of cleaning up old reports. If you still see it on a supported release, please open a new issue with the version and steps to reproduce, and link this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org