[GitHub] vongosling commented on a change in pull request #17: Update build script to "green" build, libraries will be built and saved only in rocketmq-client-cpp Instead of system path

[GitBox <gi...@apache.org>]

vongosling commented on a change in pull request #17: Update build script to "green" build, libraries will be built and saved only in rocketmq-client-cpp Instead of system path
URL: https://github.com/apache/rocketmq-client-cpp/pull/17#discussion_r237347568
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -42,43 +42,67 @@ option(BUILD_ROCKETMQ_STATIC "build rocketmq-client static library" ON)
 option(BUILD_ROCKETMQ_SHARED "build rocketmq-client shared library" ON)
 
 #Find dependency 
-set(BOOST_INCLUDEDIR /usr/local/include/)
-#set(BOOST_INCLUDEDIR C:/boost_1_56_0/)
 option(Boost_USE_STATIC_LIBS    "only find boost static libs"     ON) # only find static libs
 set(Boost_USE_MULTITHREADED          ON)
 set(Boost_USE_STATIC_RUNTIME         ON)
 if(WIN32)
     find_package(Boost 1.56 REQUIRED COMPONENTS atomic thread system chrono date_time
         log log_setup regex serialization filesystem locale iostreams zlib)
+    if(Boost_FOUND)
+        message(status "** Boost Include dir: ${Boost_INCLUDE_DIR}")
+        message(status "** Boost Libraries dir: ${Boost_LIBRARY_DIRS}")
+        message(status "** Boost Libraries: ${Boost_LIBRARIES}")
+        include_directories(${Boost_INCLUDE_DIRS})
+    endif()    
 else()
-    find_package(Boost 1.56 REQUIRED COMPONENTS atomic thread system chrono date_time log log_setup regex serialization filesystem locale iostreams) 
-endif()
-
-if(Boost_FOUND)
-    message(status "** Boost Include dir: ${Boost_INCLUDE_DIR}")
-    message(status "** Boost Libraries dir: ${Boost_LIBRARY_DIRS}")
-    message(status "** Boost Libraries: ${Boost_LIBRARIES}")
+    #find_package(Boost 1.56 REQUIRED COMPONENTS atomic thread system chrono date_time log log_setup regex serialization filesystem locale iostreams) 
+    set(Boost_INCLUDE_DIR    ${PROJECT_SOURCE_DIR}/bin/include)
+    set(Boost_LIBRARY_DIRS    ${PROJECT_SOURCE_DIR}/bin/lib)
+    set(Boost_LIBRARIES      ${Boost_LIBRARY_DIRS}/libboost_atomic.a;${Boost_LIBRARY_DIRS}/libboost_thread.a;${Boost_LIBRARY_DIRS}/libboost_system.a;${Boost_LIBRARY_DIRS}/libboost_chrono.a;
+        ${Boost_LIBRARY_DIRS}/libboost_date_time.a;${Boost_LIBRARY_DIRS}/libboost_log.a;${Boost_LIBRARY_DIRS}/libboost_log_setup.a;
+        ${Boost_LIBRARY_DIRS}/libboost_regex.a;${Boost_LIBRARY_DIRS}/libboost_serialization.a;${Boost_LIBRARY_DIRS}/libboost_filesystem.a;
+        ${Boost_LIBRARY_DIRS}/libboost_locale.a;${Boost_LIBRARY_DIRS}/libboost_iostreams.a)
     include_directories(${Boost_INCLUDE_DIRS})
 endif()
 
-#set(LIBEVENT_INCLUDE_DIR /usr/local/include/)
-option(Libevent_USE_STATIC_LIBS "only find libevent static libs"   ON) # only find static libs
-#set(Libevent_DIR    /usr/local/lib/) # only find static libs
-find_package(Libevent 2.0.22 REQUIRED COMPONENTS)
+message(status "** Boost_INCLUDE_DIR: ${Boost_INCLUDE_DIR}")
+message(status "** Boost_LIBRARIES: ${Boost_LIBRARIES}")
 
-if(LIBEVENT_FOUND)
+option(Libevent_USE_STATIC_LIBS "only find libevent static libs"   ON) # only find static libs
+if(WIN32)
+    find_package(Libevent 2.0.22 REQUIRED COMPONENTS)
+    if(LIBEVENT_FOUND)
+        include_directories(${LIBEVENT_INCLUDE_DIRS})
+        message(status "** libevent Include dir: ${LIBEVENT_INCLUDE_DIR}")
+        message(status "** libevent Libraries: ${LIBEVENT_LIBRARIES}")
+    endif()
+else()
+    #find_package(Libevent 2.0.22 REQUIRED COMPONENTS)
+    set(LIBEVENT_INCLUDE_DIRS  ${PROJECT_SOURCE_DIR}/bin/include)
+    set(LIBEVENT_LIBRARIES_DIR ${PROJECT_SOURCE_DIR}/bin/lib)
+    set(LIBEVENT_LIBRARIES     ${LIBEVENT_LIBRARIES_DIR}/libevent.a;${LIBEVENT_LIBRARIES_DIR}/libevent_core.a;${LIBEVENT_LIBRARIES_DIR}/libevent_extra.a;${LIBEVENT_LIBRARIES_DIR}/libevent_pthreads.a)
     include_directories(${LIBEVENT_INCLUDE_DIRS})
-    message(status "** libevent Include dir: ${LIBEVENT_INCLUDE_DIR}")
-    message(status "** libevent Libraries: ${LIBEVENT_LIBRARIES}")
 endif()
 
-#set(JSONCPP_INCLUDE_DIRS C:/jsoncpp-0.10.6/include)
+message(status "** LIBEVENT_INCLUDE_DIR: ${LIBEVENT_INCLUDE_DIR}")
+message(status "** LIBEVENT_LIBRARIES: ${LIBEVENT_LIBRARIES}")
+
 option(JSONCPP_USE_STATIC_LIBS  "only find jsoncpp static libs"  ON) # only find static libs
-find_package(Jsoncpp 0.10.6)
-if(JSONCPP_FOUND)
-   include_directories(${JSONCPP_INCLUDE_DIRS})
+if(WIN32)
+    find_package(Jsoncpp 0.10.6)
 
 Review comment:
   Do we consider abstract the dependency version to a constant, such as jsoncpp, libevent?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services