You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "eschutho (via GitHub)" <gi...@apache.org> on 2023/06/15 18:33:56 UTC
[GitHub] [superset] eschutho opened a new pull request, #24410: Elizabeth/fix examples load
eschutho opened a new pull request, #24410:
URL: https://github.com/apache/superset/pull/24410
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
This attempts to fix some errors that we're seeing in current builds from pre 2.1 to master of ephemerals and docker tarball testing for releases. Some tables aren't loading into sqlite because the table is locked, so I've found that retrying them here fixes the issue.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
### TESTING INSTRUCTIONS
Ephemeral environments should succeed in loading example data
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #24410: fix: retry import tables when not successful
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #24410:
URL: https://github.com/apache/superset/pull/24410#issuecomment-1593806631
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #24410: fix: retry import tables when not successful
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #24410:
URL: https://github.com/apache/superset/pull/24410#issuecomment-1593617176
I'll write some tests for this once I confirm that the fix is working here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #24410: fix: retry import tables when not successful
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24410:
URL: https://github.com/apache/superset/pull/24410#issuecomment-1593809574
@eschutho Ephemeral environment spinning up at http://35.90.254.207:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #24410: fix: force data load on import examples
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24410:
URL: https://github.com/apache/superset/pull/24410#issuecomment-1595130902
Would you rather I merge or close https://github.com/apache/superset/pull/23893 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #24410: fix: retry import tables when not successful
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24410:
URL: https://github.com/apache/superset/pull/24410#issuecomment-1593576271
@eschutho Container image not yet published for this PR. Please try again when build is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #24410: fix: retry import tables when not successful
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #24410:
URL: https://github.com/apache/superset/pull/24410#issuecomment-1593644405
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #24410: fix: force data load on import examples
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #24410:
URL: https://github.com/apache/superset/pull/24410#issuecomment-1595216071
> Would you rather I merge or close #23893 ? I should probably just close it... I'll wait for this to merge though.
Either way @rusackas. Thanks for that fix, I pulled it in here b/c it was the only way that I could test if this worked. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #24410: fix: retry import tables when not successful
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24410:
URL: https://github.com/apache/superset/pull/24410#issuecomment-1593654178
@eschutho Ephemeral environment spinning up at http://34.222.122.36:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho merged pull request #24410: fix: force data load on import examples
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho merged PR #24410:
URL: https://github.com/apache/superset/pull/24410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: force data load on import examples [superset]
Posted by "sebastianliebscher (via GitHub)" <gi...@apache.org>.
sebastianliebscher commented on PR #24410:
URL: https://github.com/apache/superset/pull/24410#issuecomment-1752007326
Hi @eschutho, while working on https://github.com/apache/superset/pull/25564 I noticed the following:
The check `if: needs.config.outputs.has-secrets` returns true in both cases when the variable has any content. So even if jobs have the check, they will run anyway.
The solution could be either to check `if: needs.config.outputs.has-secrets == 1` or don't set `has-secrets` when there are no secrets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #24410: fix: force data load on import examples
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24410:
URL: https://github.com/apache/superset/pull/24410#issuecomment-1595216647
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #24410: fix: retry import tables when not successful
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24410:
URL: https://github.com/apache/superset/pull/24410#issuecomment-1593576302
@eschutho Ephemeral environment creation failed. Please check the Actions logs for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #24410: fix: retry import tables when not successful
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #24410:
URL: https://github.com/apache/superset/pull/24410#issuecomment-1593575456
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24410: fix: retry import tables when not successful
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24410:
URL: https://github.com/apache/superset/pull/24410#issuecomment-1593558843
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24410?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24410](https://app.codecov.io/gh/apache/superset/pull/24410?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (56d7c2e) into [master](https://app.codecov.io/gh/apache/superset/commit/19a94009b0ef532d8e3b09a15f63ef068135aa0b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (19a9400) will **decrease** coverage by `10.97%`.
> The diff coverage is `85.71%`.
> :exclamation: Current head 56d7c2e differs from pull request most recent head 55a705d. Consider uploading reports for the commit 55a705d to get more accurate results
```diff
@@ Coverage Diff @@
## master #24410 +/- ##
===========================================
- Coverage 68.95% 57.98% -10.97%
===========================================
Files 1903 1904 +1
Lines 74070 74092 +22
Branches 8110 8120 +10
===========================================
- Hits 51077 42965 -8112
- Misses 20881 29015 +8134
Partials 2112 2112
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.79% <0.00%> (ø)` | |
| python | `60.50% <0.00%> (-22.82%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.56% <0.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...acy-preset-chart-deckgl/src/components/Tooltip.tsx](https://app.codecov.io/gh/apache/superset/pull/24410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWRlY2tnbC9zcmMvY29tcG9uZW50cy9Ub29sdGlwLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...lugins/plugin-chart-table/src/utils/formatValue.ts](https://app.codecov.io/gh/apache/superset/pull/24410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtdGFibGUvc3JjL3V0aWxzL2Zvcm1hdFZhbHVlLnRz) | `66.66% <0.00%> (-3.93%)` | :arrow_down: |
| [...c/components/Chart/DrillDetail/DrillDetailPane.tsx](https://app.codecov.io/gh/apache/superset/pull/24410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnQvRHJpbGxEZXRhaWwvRHJpbGxEZXRhaWxQYW5lLnRzeA==) | `75.32% <ø> (ø)` | |
| [...-frontend/src/components/TableCollection/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVDb2xsZWN0aW9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...end/src/dashboard/components/SliceHeader/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyL2luZGV4LnRzeA==) | `90.56% <ø> (ø)` | |
| [...mponents/DataTablesPane/components/SamplesPane.tsx](https://app.codecov.io/gh/apache/superset/pull/24410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9jb21wb25lbnRzL1NhbXBsZXNQYW5lLnRzeA==) | `97.67% <ø> (ø)` | |
| [...ataTablesPane/components/SingleQueryResultPane.tsx](https://app.codecov.io/gh/apache/superset/pull/24410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9jb21wb25lbnRzL1NpbmdsZVF1ZXJ5UmVzdWx0UGFuZS50c3g=) | `85.71% <ø> (ø)` | |
| [superset/datasets/commands/importers/v1/utils.py](https://app.codecov.io/gh/apache/superset/pull/24410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `77.45% <0.00%> (-1.97%)` | :arrow_down: |
| [...set-frontend/src/components/Table/VirtualTable.tsx](https://app.codecov.io/gh/apache/superset/pull/24410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGUvVmlydHVhbFRhYmxlLnRzeA==) | `75.00% <75.00%> (-0.39%)` | :arrow_down: |
| [...ponents/Chart/DrillDetail/DrillDetailMenuItems.tsx](https://app.codecov.io/gh/apache/superset/pull/24410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnQvRHJpbGxEZXRhaWwvRHJpbGxEZXRhaWxNZW51SXRlbXMudHN4) | `93.87% <80.00%> (-1.68%)` | :arrow_down: |
| ... and [7 more](https://app.codecov.io/gh/apache/superset/pull/24410?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [301 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24410/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: force data load on import examples [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #24410:
URL: https://github.com/apache/superset/pull/24410#issuecomment-1756347236
> Hi @eschutho, while working on #25564 I noticed the following:
>
> The check `if: needs.config.outputs.has-secrets` returns true in both cases when the variable has any content. So even if jobs have the check, they will run anyway.
>
> The solution could be either to check `if: needs.config.outputs.has-secrets == 1` or don't set `has-secrets` when there are no secrets.
Hi, yeah I saw your comment in the other PR, too, thanks! This was a fix that @rusackas and I brought in to fix some CI failures, but we weren't sure the absolute need for it. If it works to remove the check like in #24464 then that seems to be a good fix, if you think that will work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org