You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/12/06 11:30:45 UTC
[kudu-CR] KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5379
to review the following change.
Change subject: KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired
......................................................................
KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired
Change-Id: Icbd9b01a80ab37efe867d547362df72b019272bd
---
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
2 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/5379/1
--
To view, visit http://gerrit.cloudera.org:8080/5379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icbd9b01a80ab37efe867d547362df72b019272bd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired
......................................................................
KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired
Change-Id: Icbd9b01a80ab37efe867d547362df72b019272bd
Reviewed-on: http://gerrit.cloudera.org:8080/5379
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
2 files changed, 15 insertions(+), 0 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbd9b01a80ab37efe867d547362df72b019272bd
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired
......................................................................
Patch Set 1: Code-Review+2
Really nice find.
--
To view, visit http://gerrit.cloudera.org:8080/5379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbd9b01a80ab37efe867d547362df72b019272bd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbd9b01a80ab37efe867d547362df72b019272bd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No