You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@spark.apache.org by "Dongjoon Hyun (JIRA)" <ji...@apache.org> on 2017/02/09 21:53:41 UTC

[jira] [Closed] (SPARK-16713) Limit codegen method size to 8KB

     [ https://issues.apache.org/jira/browse/SPARK-16713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dongjoon Hyun closed SPARK-16713.
---------------------------------
    Resolution: Won't Fix

According to the discussion on PR, I think we can close this as WON'T FIX for now.

> Limit codegen method size to 8KB
> --------------------------------
>
>                 Key: SPARK-16713
>                 URL: https://issues.apache.org/jira/browse/SPARK-16713
>             Project: Spark
>          Issue Type: Improvement
>          Components: Spark Core, SQL
>    Affects Versions: 2.0.0
>            Reporter: Qifan Pu
>
> Ideally, we would wish codegen methods to be less than 8KB for bytecode size. Beyond 8K JIT won't compile and can cause performance degradation. We have seen this for queries with wide schema (30+ fields), where agg_doAggregateWithKeys() can be more than 8K. This is also a major reason for performance regression when we enable fash aggregate hashmap (such as using VectorizedHashMapGenerator.scala).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org