You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by xguo27 <gi...@git.apache.org> on 2015/12/22 20:13:56 UTC
[GitHub] spark pull request: [SPARK-12462][SQL] Add ExpressionDescription t...
GitHub user xguo27 opened a pull request:
https://github.com/apache/spark/pull/10437
[SPARK-12462][SQL] Add ExpressionDescription to misc non-aggregate functions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xguo27/spark SPARK-12462
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10437.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10437
----
commit a0e99210ea7e3068cf07b9f042a084ab8223d7f2
Author: Xiu Guo <xg...@gmail.com>
Date: 2015-12-22T18:54:52Z
[SPARK-12462][SQL] Add ExpressionDescription to misc non-aggregate functions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12462][SQL] Add ExpressionDescription t...
Posted by frreiss <gi...@git.apache.org>.
Github user frreiss commented on the pull request:
https://github.com/apache/spark/pull/10437#issuecomment-194004615
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12462][SQL] Add ExpressionDescription t...
Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10437#issuecomment-216334904
@xguo27 I think https://github.com/dongjoon-hyun/spark/commit/a7ce473bd0520c71154ed028f295dab64a7485fe has fixed this issue. Can you close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12462][SQL] Add ExpressionDescription t...
Posted by frreiss <gi...@git.apache.org>.
Github user frreiss commented on a diff in the pull request:
https://github.com/apache/spark/pull/10437#discussion_r55442828
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala ---
@@ -180,6 +190,9 @@ case class NaNvl(left: Expression, right: Expression)
/**
* An expression that is evaluated to true if the input is null.
*/
+@ExpressionDescription(
+ usage = "_FUNC_(expr) - Returns true if the input is null",
+ extended = "> SELECT _FUNC_(null);\ntrue")
--- End diff --
Might want to add an example of the standard SQL "[val] IS NULL" syntax here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12462][SQL] Add ExpressionDescription t...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10437#issuecomment-166707341
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12462][SQL] Add ExpressionDescription t...
Posted by xguo27 <gi...@git.apache.org>.
Github user xguo27 closed the pull request at:
https://github.com/apache/spark/pull/10437
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org