[GitHub] [spark] srowen commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9

[GitBox <gi...@apache.org>]

srowen commented on issue #25404: [SPARK-28683][BUILD] Upgrade Scala to 2.12.9
URL: https://github.com/apache/spark/pull/25404#issuecomment-520254908
 
 
   Wow that's a weird one, but I played with it and, bizarrely this change in the generate code makes it work:
   
   ```
         } else if ($o2 == null) {
           return -$sortOrder * $nullOrder;
         }
   ```
   
   to
   
   ```
         } else if ($o2 == null) {
           return -$sortOrder * ${nullOrder.toString};
         }
   ```
   
   I can only guess something goes wrong in string interpolation because `nullOrder` is a `NullOrder` and typedef for an `Int`, and is boxed to `Integer` somewhere, but something believes it is a String.
   
   ... and then I decided to search for open bugs and yep this is it:
   https://github.com/scala/bug/issues/11665
   
   We may just need to wait for 2.12.10

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org