You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "yuzelin (via GitHub)" <gi...@apache.org> on 2023/04/14 06:06:18 UTC

[GitHub] [incubator-paimon] yuzelin opened a new pull request, #909: [flink][bug] Fix CDC Ingestion mysql DATETIME type cast error

yuzelin opened a new pull request, #909:
URL: https://github.com/apache/incubator-paimon/pull/909

   ### Purpose
   Fix #860 
   
   fix DATETIME type cast logic.
   
   ### Tests
   
   `MySqlSyncTableActionITCase#testAllTypes`
   
   ### API and Format 
   
   No
   
   ### Documentation
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-paimon] yuzelin commented on pull request #909: [flink][bug] Fix CDC Ingestion mysql DATETIME type cast error

Posted by "yuzelin (via GitHub)" <gi...@apache.org>.
yuzelin commented on PR #909:
URL: https://github.com/apache/incubator-paimon/pull/909#issuecomment-1521441122

   @zhengshubin Hi, fixed: https://github.com/apache/incubator-paimon/pull/1014


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-paimon] yuzelin commented on pull request #909: [flink][bug] Fix CDC Ingestion mysql DATETIME type cast error

Posted by "yuzelin (via GitHub)" <gi...@apache.org>.
yuzelin commented on PR #909:
URL: https://github.com/apache/incubator-paimon/pull/909#issuecomment-1521107871

   @zhengshubin Thanks for reporting. I will try to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #909: [flink][bug] Fix CDC Ingestion mysql DATETIME type cast error

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #909:
URL: https://github.com/apache/incubator-paimon/pull/909#discussion_r1166417615


##########
paimon-flink/paimon-flink-common/src/test/resources/mysql/setup.sql:
##########
@@ -95,20 +115,39 @@ CREATE TABLE all_types_table (
 
 INSERT INTO all_types_table VALUES (
     1,
+    -- TINYINT
     true, 1, 2, 3,
+    -- SMALLINT
     1000, 2000, 3000,
+    -- MEDIUMINT
     100000, 200000, 300000,
+    -- INT
     1000000, 2000000, 3000000,
+    -- BIGINT
     10000000000, 20000000000, 30000000000, 40000000000,
+    -- FLOAT
     1.5, 2.5, 3.5,
+    -- REAL
     1.000001, 2.000002, 3.000003,
+    -- DOUBLE
     1.000011, 2.000022, 3.000033,
+    -- DOUBLE PRECISION
     1.000111, 2.000222, 3.000333,
+    -- NUMERIC
     12345.11, 12345.22, 12345.33,
+    -- FIXED
     123456789876543212345678987654321.11, 123456789876543212345678987654321.22, 123456789876543212345678987654321.33,
+    -- DECIMAL
     11111, 22222, 33333,
-    '2023-03-23', '2023-03-23 14:30:05', '2023-03-23 15:00:10.123456',
+    -- DATE
+    '2023-03-23',
+    -- DATETIME
+    '2023-03-23 14:30:05', '2023-03-23 14:30:05.123', '2023-03-23 14:30:05.123456',

Review Comment:
   Add data `'2023-03-23 14:30'`



##########
paimon-flink/paimon-flink-common/src/test/resources/mysql/setup.sql:
##########
@@ -95,20 +115,39 @@ CREATE TABLE all_types_table (
 
 INSERT INTO all_types_table VALUES (
     1,
+    -- TINYINT
     true, 1, 2, 3,
+    -- SMALLINT
     1000, 2000, 3000,
+    -- MEDIUMINT
     100000, 200000, 300000,
+    -- INT
     1000000, 2000000, 3000000,
+    -- BIGINT
     10000000000, 20000000000, 30000000000, 40000000000,
+    -- FLOAT
     1.5, 2.5, 3.5,
+    -- REAL
     1.000001, 2.000002, 3.000003,
+    -- DOUBLE
     1.000011, 2.000022, 3.000033,
+    -- DOUBLE PRECISION
     1.000111, 2.000222, 3.000333,
+    -- NUMERIC
     12345.11, 12345.22, 12345.33,
+    -- FIXED
     123456789876543212345678987654321.11, 123456789876543212345678987654321.22, 123456789876543212345678987654321.33,
+    -- DECIMAL
     11111, 22222, 33333,
-    '2023-03-23', '2023-03-23 14:30:05', '2023-03-23 15:00:10.123456',
+    -- DATE
+    '2023-03-23',
+    -- DATETIME
+    '2023-03-23 14:30:05', '2023-03-23 14:30:05.123', '2023-03-23 14:30:05.123456',

Review Comment:
   Add data `'2023-03-23 14:30:00'`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-paimon] yuzelin commented on pull request #909: [flink][bug] Fix CDC Ingestion mysql DATETIME type cast error

Posted by "yuzelin (via GitHub)" <gi...@apache.org>.
yuzelin commented on PR #909:
URL: https://github.com/apache/incubator-paimon/pull/909#issuecomment-1508365414

   ![354466C8-74F2-4798-93B9-ED1A7FCB5A7A](https://user-images.githubusercontent.com/33053040/232032125-da55ccad-9f20-4ae1-9a02-163d5cc9d1d1.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-paimon] JingsongLi merged pull request #909: [flink][bug] Fix CDC Ingestion mysql DATETIME type cast error

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #909:
URL: https://github.com/apache/incubator-paimon/pull/909


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-paimon] zhengshubin commented on pull request #909: [flink][bug] Fix CDC Ingestion mysql DATETIME type cast error

Posted by "zhengshubin (via GitHub)" <gi...@apache.org>.
zhengshubin commented on PR #909:
URL: https://github.com/apache/incubator-paimon/pull/909#issuecomment-1521058841

   mysql  type TIMESTAMP also make error : Failed to convert value 2023-04-01 00:10 to type TIMESTAMP(6). Waiting for schema update.
   java.time.format.DateTimeParseException: Text '2023-04-01 00:10' could not be parsed, unparsed text found at index 10


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org