[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9215: Keep topic-level policies commands consistent with that for namespace…

[GitBox <gi...@apache.org>]

Jennifer88huang commented on a change in pull request #9215:
URL: https://github.com/apache/pulsar/pull/9215#discussion_r558087341



##########
File path: pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/PulsarAdminToolTest.java
##########
@@ -764,10 +764,7 @@ public void topics() throws Exception {
         cmdTopics.run(split("peek-messages persistent://myprop/clust/ns1/ds1 -s sub1 -n 3"));
         verify(mockTopics).peekMessages("persistent://myprop/clust/ns1/ds1", "sub1", 3);
 
-        cmdTopics.run(split("enable-deduplication persistent://myprop/clust/ns1/ds1"));
-        verify(mockTopics).enableDeduplication("persistent://myprop/clust/ns1/ds1", true);
-
-        cmdTopics.run(split("disable-deduplication persistent://myprop/clust/ns1/ds1"));
+        cmdTopics.run(split("set-deduplication persistent://myprop/clust/ns1/ds1 --disable"));
         verify(mockTopics).enableDeduplication("persistent://myprop/clust/ns1/ds1", false);

Review comment:
       since we refine "enable-deduplication" as "set-deduplication", we still have "get-deduplication-enabled" below. What's the differences?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org