[GitHub] [pinot] Jackie-Jiang commented on pull request #9308: Deprecate instanceId Config For Broker/Minion Specific Configs

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on PR #9308:
URL: https://github.com/apache/pinot/pull/9308#issuecomment-1239799497

   > > Currently controller and server is using pinot..instance.id as the key, I'd suggest making broker and minion following the same pattern to be consistent
   > 
   > @Jackie-Jiang : We might need to deprecate pinot.broker.id as well in that case. Is that okay?
   
   @ankitsultana Per the current logic, I think we can directly modify the `CONFIG_OF_BROKER_ID` to `pinot.broker.instance.id` without worrying about backward compatibility because the field is always set within the `BaseBrokerStarter` and then read again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org