You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Andrew Wang (JIRA)" <ji...@apache.org> on 2016/10/05 22:25:20 UTC

[jira] [Commented] (HADOOP-13688) Stop bundling HTML source code in javadoc JARs

    [ https://issues.apache.org/jira/browse/HADOOP-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550134#comment-15550134 ] 

Andrew Wang commented on HADOOP-13688:
--------------------------------------

The other issue I noticed is that there seems to be tons of extra content in the javadoc jars, like other jars and classfiles. It looks like it's sucking down the entire target directory:

After unzipping the hadoop-common javadoc jar:

{noformat}
-> % ls
allclasses-frame.html    findbugsXml.xml                                       hadoop-maven-plugins-protoc-checksums.json  META-INF               src-html
allclasses-noframe.html  generated-sources                                     help-doc.html                               org                    stylesheet.css
antrun                   generated-test-sources                                index-all.html                              overview-frame.html    test
archive-tmp              hadoop-annotations.jar                                index.html                                  overview-summary.html  test-classes
classes                  hadoop-common-3.0.0-alpha2-SNAPSHOT                   javadoc-bundle-options                      overview-tree.html     test-dir
constant-values.html     hadoop-common-3.0.0-alpha2-SNAPSHOT.jar               jdiff.jar                                   package-list           xerces.jar
deprecated-list.html     hadoop-common-3.0.0-alpha2-SNAPSHOT-sources.jar       log                                         script.js
docs-src                 hadoop-common-3.0.0-alpha2-SNAPSHOT-tests.jar         maven-archiver                              serialized-form.html
findbugsExcludeFile.xml  hadoop-common-3.0.0-alpha2-SNAPSHOT-test-sources.jar  maven-shared-archive-resources              site
andrew@zanarkand [03:21:07 PM] [/tmp/javadoc] 
-> % find . -name "*.class" | wc -l 
3455
andrew@zanarkand [03:21:11 PM] [/tmp/javadoc] 
-> % find . -name "*.jar" | wc -l
85
-> % find . -name "*.jar" -exec wc -c {} \; | awk -e '{SUM+=$1} END {print SUM}' 
41692556
{noformat}

Since the jarfiles by themselves are another 41MB, there's the potential to really streamline the javadoc jars.

> Stop bundling HTML source code in javadoc JARs
> ----------------------------------------------
>
>                 Key: HADOOP-13688
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13688
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 2.6.4
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: HADOOP-13688.001.patch
>
>
> We generate source code with line numbers for inclusion in the javadoc JARs. Given that there's github and other online viewers, this doesn't seem so useful these days.
> Disabling the "linkSource" option saves us 40MB for the hadoop-common javadoc jar:
> {noformat}
> -rw-r--r-- 1 andrew andrew 98M Oct  5 14:44 hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> -rw-r--r-- 1 andrew andrew 58M Oct  5 15:00 ./hadoop-common-project/hadoop-common/target/hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org