You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/10/27 19:24:04 UTC
[GitHub] [accumulo] milleruntime opened a new pull request #2332: Make CleanUp shutdownNow close Connector
milleruntime opened a new pull request #2332:
URL: https://github.com/apache/accumulo/pull/2332
* Recent changes in #2303 made static ThriftTransportPool a part of
ClientContext. In order to allow legacy Connector clean up the threads
as it did previously, make the shutdownNow method take a connector and
call close on it. Made null an option in case the Connector is
unavailable to pass as a parameter.
* Fixes failure in CleanUpIT. Partial fix of #2327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2332: Make CleanUp shutdownNow close Connector
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2332:
URL: https://github.com/apache/accumulo/pull/2332#issuecomment-953868025
> Unlinked since it will close the issue before both ITs are fixed.
Thanks. I thought if I put extra words in the comment it wouldn't grab it haha
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2332: Make CleanUp shutdownNow close Connector
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #2332:
URL: https://github.com/apache/accumulo/pull/2332#issuecomment-953967015
> > Unlinked since it will close the issue before both ITs are fixed.
>
> Thanks. I thought if I put extra words in the comment it wouldn't grab it haha
It should still be linked. The issue can be re-opened until it is closed by the other fix. I will re-link it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a change in pull request #2332: Make CleanUp shutdownNow close Connector
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #2332:
URL: https://github.com/apache/accumulo/pull/2332#discussion_r738509870
##########
File path: core/src/main/java/org/apache/accumulo/core/util/CleanUp.java
##########
@@ -21,6 +21,8 @@
import java.util.Set;
import org.apache.accumulo.core.client.AccumuloClient;
+import org.apache.accumulo.core.client.Connector;
+import org.apache.accumulo.core.clientImpl.ConnectorImpl;
Review comment:
I didn't see any warnings in the build output. Perhaps since the class is deprecated, it doesn't care about the imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on pull request #2332: Make CleanUp shutdownNow close Connector
Posted by GitBox <gi...@apache.org>.
Manno15 commented on pull request #2332:
URL: https://github.com/apache/accumulo/pull/2332#issuecomment-953377823
Unlinked since it will close the issue before both ITs are fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #2332: Make CleanUp shutdownNow close Connector
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #2332:
URL: https://github.com/apache/accumulo/pull/2332#discussion_r737819101
##########
File path: core/src/main/java/org/apache/accumulo/core/util/CleanUp.java
##########
@@ -47,10 +49,17 @@
/**
* kills all threads created by internal Accumulo singleton resources. After this method is
* called, no Connector will work in the current classloader.
+ *
+ * @param conn
+ * If available, Connector object to close resources on. Will accept null otherwise.
*/
- public static void shutdownNow() {
+ public static void shutdownNow(Connector conn) {
Review comment:
Should be fine since this isn't public API.
##########
File path: core/src/main/java/org/apache/accumulo/core/util/CleanUp.java
##########
@@ -21,6 +21,8 @@
import java.util.Set;
import org.apache.accumulo.core.client.AccumuloClient;
+import org.apache.accumulo.core.client.Connector;
+import org.apache.accumulo.core.clientImpl.ConnectorImpl;
Review comment:
I think these are deprecated. You may need to avoid imports of these to avoid unnecessary warnings about deprecated classes being referenced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime merged pull request #2332: Make CleanUp shutdownNow close Connector
Posted by GitBox <gi...@apache.org>.
milleruntime merged pull request #2332:
URL: https://github.com/apache/accumulo/pull/2332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #2332: Make CleanUp shutdownNow close Connector
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #2332:
URL: https://github.com/apache/accumulo/pull/2332#discussion_r738521519
##########
File path: core/src/main/java/org/apache/accumulo/core/util/CleanUp.java
##########
@@ -21,6 +21,8 @@
import java.util.Set;
import org.apache.accumulo.core.client.AccumuloClient;
+import org.apache.accumulo.core.client.Connector;
+import org.apache.accumulo.core.clientImpl.ConnectorImpl;
Review comment:
I didn't realize CleanUp was deprecated. That makes sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org