[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8864: add sequenceName and currentCheckPoint for backwards compatibility

[GitBox <gi...@apache.org>]

ccaominh commented on a change in pull request #8864: add sequenceName and currentCheckPoint for backwards compatibility
URL: https://github.com/apache/incubator-druid/pull/8864#discussion_r346075809
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/common/actions/CheckPointDataSourceMetadataAction.java
 ##########
 @@ -75,6 +75,28 @@ public SeekableStreamDataSourceMetadata getPreviousCheckPoint()
     return checkpointMetadata;
   }
 
+  // For backwards compatibility
 
 Review comment:
   Can add a unit test for the serialization/deserialization between old and new DTOs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org