You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2016/01/07 13:35:33 UTC
Re: Review Request 41857: WIP: Got evictable executors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/
-----------------------------------------------------------
(Updated Jan. 7, 2016, 8:35 p.m.)
Review request for mesos and Guangya Liu.
Summary (updated)
-----------------
WIP: Got evictable executors.
Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892
Repository: mesos
Description
-------
get evictable executors
Diffs
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41857/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41857: Got evictable executors.
Posted by Klaus Ma <kl...@gmail.com>.
> On Jan. 8, 2016, 4:36 p.m., Jian Qiu wrote:
> > src/slave/slave.cpp, line 3985
> > <https://reviews.apache.org/r/41857/diff/3/?file=1187189#file1187189line3985>
> >
> > I am not sure whether this situation will happen, because it means a task using allocation slack and is waiting for evicting executor. Master should not allowed such task to be launched beacause there not enough available allocation slack resources for this task
Good catch!
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/#review113430
-----------------------------------------------------------
On Jan. 9, 2016, 5:06 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41857/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2016, 5:06 p.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
>
>
> Bugs: MESOS-3892
> https://issues.apache.org/jira/browse/MESOS-3892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> get evictable executors
>
>
> Diffs
> -----
>
> src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
> src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
>
> Diff: https://reviews.apache.org/r/41857/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41857: Got evictable executors.
Posted by Klaus Ma <kl...@gmail.com>.
> On Jan. 8, 2016, 4:36 p.m., Jian Qiu wrote:
> > src/slave/slave.cpp, line 3967
> > <https://reviews.apache.org/r/41857/diff/3/?file=1187189#file1187189line3967>
> >
> > this check may not be necessary because resources cannot be negative?
Yes; it won't be negative, but it'll return first resources instead of empty.
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/#review113430
-----------------------------------------------------------
On Jan. 8, 2016, 2:54 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41857/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 2:54 p.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
>
>
> Bugs: MESOS-3892
> https://issues.apache.org/jira/browse/MESOS-3892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> get evictable executors
>
>
> Diffs
> -----
>
> src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
> src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
>
> Diff: https://reviews.apache.org/r/41857/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41857: Got evictable executors.
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/#review113430
-----------------------------------------------------------
src/slave/slave.cpp (line 3963)
<https://reviews.apache.org/r/41857/#comment174066>
s/pinding/pending
src/slave/slave.cpp (line 3967)
<https://reviews.apache.org/r/41857/#comment174067>
this check may not be necessary because resources cannot be negative?
src/slave/slave.cpp (line 3985)
<https://reviews.apache.org/r/41857/#comment174079>
I am not sure whether this situation will happen, because it means a task using allocation slack and is waiting for evicting executor. Master should not allowed such task to be launched beacause there not enough available allocation slack resources for this task
- Jian Qiu
On 一月 8, 2016, 6:54 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41857/
> -----------------------------------------------------------
>
> (Updated 一月 8, 2016, 6:54 a.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
>
>
> Bugs: MESOS-3892
> https://issues.apache.org/jira/browse/MESOS-3892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> get evictable executors
>
>
> Diffs
> -----
>
> src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
> src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
>
> Diff: https://reviews.apache.org/r/41857/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41857: Got evictable executors.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/
-----------------------------------------------------------
(Updated March 11, 2016, 2:52 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Changes
-------
rebase
Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892
Repository: mesos
Description
-------
get evictable executors
Diffs (updated)
-----
src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762
src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697
Diff: https://reviews.apache.org/r/41857/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41857: Got evictable executors.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 8:18 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Changes
-------
Return empty list instead of None() when no executors to evict.
Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892
Repository: mesos
Description
-------
get evictable executors
Diffs (updated)
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41857/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41857: Got evictable executors.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/
-----------------------------------------------------------
(Updated Jan. 9, 2016, 5:06 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Changes
-------
Address comments
Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892
Repository: mesos
Description
-------
get evictable executors
Diffs (updated)
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41857/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41857: Got evictable executors.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/
-----------------------------------------------------------
(Updated Jan. 8, 2016, 2:54 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Summary (updated)
-----------------
Got evictable executors.
Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892
Repository: mesos
Description
-------
get evictable executors
Diffs
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41857/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41857: WIP: Got evictable executors.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/
-----------------------------------------------------------
(Updated Jan. 8, 2016, 2:51 p.m.)
Review request for mesos and Guangya Liu.
Changes
-------
Add more logs
Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892
Repository: mesos
Description
-------
get evictable executors
Diffs (updated)
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41857/diff/
Testing
-------
Thanks,
Klaus Ma