You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Young-Seok Kim (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/05/12 03:06:34 UTC
Change in asterixdb[master]: ASTERIXDB-1434: fixed RecoveryIT failure test
Young-Seok Kim has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/845
Change subject: ASTERIXDB-1434: fixed RecoveryIT failure test
......................................................................
ASTERIXDB-1434: fixed RecoveryIT failure test
- Fixed Recovery IT failure test. There has been a lurking bug
which always set the isPrimaryIndex flag to true incorrectly for
secondary LSMBTree indexes. The bug surfaced out from the
recent change which removed a Bloom filter from secondary
LSMBTree indexes.
Change-Id: I85bc3c8445c10da8f2a8c2f334d1eeefb1c0662a
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryBTreeOperationsHelper.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/45/845/1
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryBTreeOperationsHelper.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryBTreeOperationsHelper.java
index 6a6538e..c793f59 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryBTreeOperationsHelper.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryBTreeOperationsHelper.java
@@ -91,7 +91,7 @@
if (dataset.getDatasetType() == DatasetType.INTERNAL) {
//prepare a LocalResourceMetadata which will be stored in NC's local resource repository
ILocalResourceMetadata localResourceMetadata = new LSMBTreeLocalResourceMetadata(secondaryTypeTraits,
- secondaryComparatorFactories, secondaryBloomFilterKeyFields, true, dataset.getDatasetId(),
+ secondaryComparatorFactories, secondaryBloomFilterKeyFields, false, dataset.getDatasetId(),
mergePolicyFactory, mergePolicyFactoryProperties, filterTypeTraits, filterCmpFactories,
secondaryBTreeFields, secondaryFilterFields);
localResourceFactoryProvider = new PersistentLocalResourceFactoryProvider(localResourceMetadata,
--
To view, visit https://asterix-gerrit.ics.uci.edu/845
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85bc3c8445c10da8f2a8c2f334d1eeefb1c0662a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Young-Seok Kim <ki...@gmail.com>
Change in asterixdb[master]: ASTERIXDB-1434: fixed RecoveryIT failure test
Posted by "Michael Blow (Code Review)" <do...@asterixdb.incubator.apache.org>.
Michael Blow has posted comments on this change.
Change subject: ASTERIXDB-1434: fixed RecoveryIT failure test
......................................................................
Patch Set 1: Code-Review+2
Grabbed this change and verified this fixes integration tests.
--
To view, visit https://asterix-gerrit.ics.uci.edu/845
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85bc3c8445c10da8f2a8c2f334d1eeefb1c0662a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Young-Seok Kim <ki...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1434: fixed RecoveryIT failure test
Posted by "Young-Seok Kim (Code Review)" <do...@asterixdb.incubator.apache.org>.
Young-Seok Kim has submitted this change and it was merged.
Change subject: ASTERIXDB-1434: fixed RecoveryIT failure test
......................................................................
ASTERIXDB-1434: fixed RecoveryIT failure test
- Fixed Recovery IT failure test. There has been a lurking bug
which always set the isPrimaryIndex flag to true incorrectly for
secondary LSMBTree indexes. The bug surfaced out from the
recent change which removed a Bloom filter from secondary
LSMBTree indexes.
Change-Id: I85bc3c8445c10da8f2a8c2f334d1eeefb1c0662a
Reviewed-on: https://asterix-gerrit.ics.uci.edu/845
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Michael Blow <mi...@couchbase.com>
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryBTreeOperationsHelper.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Blow: Looks good to me, approved
Jenkins: Verified
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryBTreeOperationsHelper.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryBTreeOperationsHelper.java
index 6a6538e..c793f59 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryBTreeOperationsHelper.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryBTreeOperationsHelper.java
@@ -91,7 +91,7 @@
if (dataset.getDatasetType() == DatasetType.INTERNAL) {
//prepare a LocalResourceMetadata which will be stored in NC's local resource repository
ILocalResourceMetadata localResourceMetadata = new LSMBTreeLocalResourceMetadata(secondaryTypeTraits,
- secondaryComparatorFactories, secondaryBloomFilterKeyFields, true, dataset.getDatasetId(),
+ secondaryComparatorFactories, secondaryBloomFilterKeyFields, false, dataset.getDatasetId(),
mergePolicyFactory, mergePolicyFactoryProperties, filterTypeTraits, filterCmpFactories,
secondaryBTreeFields, secondaryFilterFields);
localResourceFactoryProvider = new PersistentLocalResourceFactoryProvider(localResourceMetadata,
--
To view, visit https://asterix-gerrit.ics.uci.edu/845
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85bc3c8445c10da8f2a8c2f334d1eeefb1c0662a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Young-Seok Kim <ki...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Young-Seok Kim <ki...@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Change in asterixdb[master]: ASTERIXDB-1434: fixed RecoveryIT failure test
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1434: fixed RecoveryIT failure test
......................................................................
Patch Set 1: Verified+1
Build Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1314/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/845
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85bc3c8445c10da8f2a8c2f334d1eeefb1c0662a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Young-Seok Kim <ki...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1434: fixed RecoveryIT failure test
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1434: fixed RecoveryIT failure test
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1314/
--
To view, visit https://asterix-gerrit.ics.uci.edu/845
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85bc3c8445c10da8f2a8c2f334d1eeefb1c0662a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Young-Seok Kim <ki...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No