You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2022/12/26 13:20:44 UTC
[camel] branch main updated: camel-yaml-dsl - Suppress PMD warning in source generated code
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new 2b1566aa16e camel-yaml-dsl - Suppress PMD warning in source generated code
2b1566aa16e is described below
commit 2b1566aa16e2021b3fc1ebd3f3f43f15aba39068
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Mon Dec 26 14:20:07 2022 +0100
camel-yaml-dsl - Suppress PMD warning in source generated code
---
.../camel/dsl/yaml/deserializers/ExpressionDeserializers.java | 2 ++
.../camel/dsl/yaml/deserializers/ModelDeserializers.java | 2 ++
.../camel/maven/dsl/yaml/GenerateYamlDeserializersMojo.java | 10 ++++++++++
3 files changed, 14 insertions(+)
diff --git a/dsl/camel-yaml-dsl/camel-yaml-dsl-deserializers/src/generated/java/org/apache/camel/dsl/yaml/deserializers/ExpressionDeserializers.java b/dsl/camel-yaml-dsl/camel-yaml-dsl-deserializers/src/generated/java/org/apache/camel/dsl/yaml/deserializers/ExpressionDeserializers.java
index 99e43fd38cf..e120ea8bd74 100644
--- a/dsl/camel-yaml-dsl/camel-yaml-dsl-deserializers/src/generated/java/org/apache/camel/dsl/yaml/deserializers/ExpressionDeserializers.java
+++ b/dsl/camel-yaml-dsl/camel-yaml-dsl-deserializers/src/generated/java/org/apache/camel/dsl/yaml/deserializers/ExpressionDeserializers.java
@@ -4,6 +4,7 @@ package org.apache.camel.dsl.yaml.deserializers;
import java.lang.Object;
import java.lang.Override;
import java.lang.String;
+import java.lang.SuppressWarnings;
import org.apache.camel.dsl.yaml.common.YamlDeserializationContext;
import org.apache.camel.dsl.yaml.common.YamlDeserializerSupport;
import org.apache.camel.model.language.ExpressionDefinition;
@@ -14,6 +15,7 @@ import org.snakeyaml.engine.v2.nodes.MappingNode;
import org.snakeyaml.engine.v2.nodes.Node;
import org.snakeyaml.engine.v2.nodes.NodeTuple;
+@SuppressWarnings("PMD.UnnecessaryFullyQualifiedName")
public final class ExpressionDeserializers extends YamlDeserializerSupport {
private ExpressionDeserializers() {
}
diff --git a/dsl/camel-yaml-dsl/camel-yaml-dsl-deserializers/src/generated/java/org/apache/camel/dsl/yaml/deserializers/ModelDeserializers.java b/dsl/camel-yaml-dsl/camel-yaml-dsl-deserializers/src/generated/java/org/apache/camel/dsl/yaml/deserializers/ModelDeserializers.java
index f57d04256ca..5a1385a78ab 100644
--- a/dsl/camel-yaml-dsl/camel-yaml-dsl-deserializers/src/generated/java/org/apache/camel/dsl/yaml/deserializers/ModelDeserializers.java
+++ b/dsl/camel-yaml-dsl/camel-yaml-dsl-deserializers/src/generated/java/org/apache/camel/dsl/yaml/deserializers/ModelDeserializers.java
@@ -4,6 +4,7 @@ package org.apache.camel.dsl.yaml.deserializers;
import java.lang.Object;
import java.lang.Override;
import java.lang.String;
+import java.lang.SuppressWarnings;
import java.util.Map;
import org.apache.camel.CamelContext;
import org.apache.camel.dsl.yaml.common.YamlDeserializerBase;
@@ -238,6 +239,7 @@ import org.apache.camel.spi.annotations.YamlType;
import org.snakeyaml.engine.v2.nodes.MappingNode;
import org.snakeyaml.engine.v2.nodes.Node;
+@SuppressWarnings("PMD.UnnecessaryFullyQualifiedName")
public final class ModelDeserializers extends YamlDeserializerSupport {
private ModelDeserializers() {
}
diff --git a/dsl/camel-yaml-dsl/camel-yaml-dsl-maven-plugin/src/main/java/org/apache/camel/maven/dsl/yaml/GenerateYamlDeserializersMojo.java b/dsl/camel-yaml-dsl/camel-yaml-dsl-maven-plugin/src/main/java/org/apache/camel/maven/dsl/yaml/GenerateYamlDeserializersMojo.java
index 0759ffe4a24..02d83e54eb1 100644
--- a/dsl/camel-yaml-dsl/camel-yaml-dsl-maven-plugin/src/main/java/org/apache/camel/maven/dsl/yaml/GenerateYamlDeserializersMojo.java
+++ b/dsl/camel-yaml-dsl/camel-yaml-dsl-maven-plugin/src/main/java/org/apache/camel/maven/dsl/yaml/GenerateYamlDeserializersMojo.java
@@ -115,6 +115,11 @@ public class GenerateYamlDeserializersMojo extends GenerateYamlSupportMojo {
type.addModifiers(Modifier.PUBLIC, Modifier.FINAL);
type.superclass(CN_DESERIALIZER_SUPPORT);
+ // PMD suppression
+ AnnotationSpec.Builder suppress = AnnotationSpec.builder(SuppressWarnings.class);
+ suppress.addMember("value", "$L", "\"PMD.UnnecessaryFullyQualifiedName\"");
+ type.addAnnotation(suppress.build());
+
// add private constructor
type.addMethod(MethodSpec.constructorBuilder()
.addModifiers(Modifier.PRIVATE)
@@ -295,6 +300,11 @@ public class GenerateYamlDeserializersMojo extends GenerateYamlSupportMojo {
deserializers.addModifiers(Modifier.PUBLIC, Modifier.FINAL);
deserializers.superclass(CN_DESERIALIZER_SUPPORT);
+ // PMD suppression
+ AnnotationSpec.Builder suppress = AnnotationSpec.builder(SuppressWarnings.class);
+ suppress.addMember("value", "$L", "\"PMD.UnnecessaryFullyQualifiedName\"");
+ deserializers.addAnnotation(suppress.build());
+
// add private constructor
deserializers.addMethod(MethodSpec.constructorBuilder()
.addModifiers(Modifier.PRIVATE)