You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by cs...@apache.org on 2019/06/27 11:52:46 UTC
[impala] 02/07: IMPALA-8702: Remove the PlannerTestOption of
VALIDATE_CARDINALITY to avoid a flaky test
This is an automated email from the ASF dual-hosted git repository.
csringhofer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit c9937fd99a3a0f52124797374da76a9d2d25f650
Author: Fang-Yu Rao <fa...@cloudera.com>
AuthorDate: Mon Jun 24 15:33:00 2019 -0700
IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test
Removed the PlannerTestOption of VALIDATE_CARDINALITY in testJoins()
and testFkPkJoinDetection() to avoid checking the estimated cardinality which
may be slightly different each time due to IMPALA-7608 when an hdfs table
without stats is involved in a query.
Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187
Reviewed-on: http://gerrit.cloudera.org:8080/13717
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
fe/src/test/java/org/apache/impala/planner/PlannerTest.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fe/src/test/java/org/apache/impala/planner/PlannerTest.java b/fe/src/test/java/org/apache/impala/planner/PlannerTest.java
index 7f9d448..524f896 100644
--- a/fe/src/test/java/org/apache/impala/planner/PlannerTest.java
+++ b/fe/src/test/java/org/apache/impala/planner/PlannerTest.java
@@ -219,8 +219,9 @@ public class PlannerTest extends PlannerTestBase {
public void testJoins() {
TQueryOptions options = defaultQueryOptions();
options.setDisable_hdfs_num_rows_estimate(false);
- runPlannerTestFile("joins-hdfs-num-rows-est-enabled", options,
- ImmutableSet.of(PlannerTestOption.VALIDATE_CARDINALITY));
+ // Skip cardinality validation because some tables do not have stats
+ // and estimated file sizes are non-deterministic.
+ runPlannerTestFile("joins-hdfs-num-rows-est-enabled", options);
}
@Test
@@ -255,8 +256,7 @@ public class PlannerTest extends PlannerTestBase {
TQueryOptions options = defaultQueryOptions();
options.setDisable_hdfs_num_rows_estimate(false);
runPlannerTestFile("fk-pk-join-detection-hdfs-num-rows-est-enabled",
- options, ImmutableSet.of(PlannerTestOption.EXTENDED_EXPLAIN,
- PlannerTestOption.VALIDATE_CARDINALITY));
+ options, ImmutableSet.of(PlannerTestOption.EXTENDED_EXPLAIN));
}
@Test