You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/05/05 20:49:53 UTC

[kudu-CR] [client] KUDU-3472 C++ client API to import JWT

Hello Marton Greber, Zoltan Chovan, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19808

to look at the new patch set (#2).

Change subject: [client] KUDU-3472 C++ client API to import JWT
......................................................................

[client] KUDU-3472 C++ client API to import JWT

This patch addresses add C++ client API to specify a JWT for a newly
built C++ client instance.  It's an improvement in the usability of the
Kudu client API since with this new extra method the users don't need
to mess with the serialization of the authn credentials.

The new functionality is covered by already existing tests that have
been updated to start using the new API.  More tests might be added
to cover other aspects of the JWT-related functionality, but these
are not directly related to this API change, so we can take care of them
in a separate patch.

Change-Id: I8333f1d0c3b4e92ef8430c7ad91bb7da963aceb9
---
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client_builder-internal.h
M src/kudu/integration-tests/security-itest.cc
4 files changed, 87 insertions(+), 60 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/19808/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8333f1d0c3b4e92ef8430c7ad91bb7da963aceb9
Gerrit-Change-Number: 19808
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>