[GitHub] [airflow] ToxaZ opened a new pull request #5688: [AIRFLOW-5073] Treat NULL as fail in SQL sensor

[GitBox <gi...@apache.org>]

ToxaZ opened a new pull request #5688: [AIRFLOW-5073] Treat NULL as fail in SQL sensor
URL: https://github.com/apache/airflow/pull/5688
 
 
   Change SQLSensor to treat NULL as fail. Add boolean allow_null
   parameter to support legacy behavior passing NULL as success.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following:
     - https://issues.apache.org/jira/browse/AIRFLOW-5073
   
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   - switches NULL response to 'failed' result instead of 'success'
   - adds `allow_true` parameter to preserve previous behaviour
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   - tests are extremely trivial, but I can add them if needed
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [X] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services