[jira] [Commented] (AIRFLOW-5533) CRON job fails when running static checks

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935373#comment-16935373 ] 

ASF GitHub Bot commented on AIRFLOW-5533:
-----------------------------------------

potiuk commented on pull request #6167: [AIRFLOW-5533] Fixed failing CRON build
URL: https://github.com/apache/airflow/pull/6167
 
 
   This change optimises further image building and removes unnecessary
   verbosity in building the images for CI builds.
   
   After this change is merged, only the necessary images are built for
   each type of check:
   * Tests -> only CI
   * Static checks (with/without pylint) -> Only CI_SLIM
   * Docs -> only CI_SLIM
   * Licence checks -> Only CHECKLICENCE
   
   Previously the right images only were built in ci_before_install.sh
   but then in case of static checks, the pre-commit build image step
   also rebuilt CHECKLICENCE and CI images - which was not necessary
   and very long in case of CRON job - this caused the CRON job to
   fail at 10m of inactivity.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> CRON job fails when running static checks
> -----------------------------------------
>
>                 Key: AIRFLOW-5533
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5533
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ci
>    Affects Versions: 2.0.0, 1.10.5
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> CRON job fails on static checks.
> This is because the whole image is rebuilt from the scratch and it turned out that while running static checks it was also rebuilding CI/CHECKLICENCE images even though they were not needed (only CI_SLIM) images are needed for static checks.
> This was done in silent mode and took long time (because it is build from the scratch) resulting in 10m inactivity. It also means that the builds on CI can be still sped up because the images are also being built without a need in regular jobs (but faster).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)