You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/02/21 12:13:54 UTC

[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #77: Move header check into its own github actions workflow

mdedetrich commented on code in PR #77:
URL: https://github.com/apache/incubator-pekko-http/pull/77#discussion_r1112972450


##########
.github/workflows/check-headers.yml:
##########
@@ -0,0 +1,32 @@
+name: Headers
+
+on:
+  pull_request:
+
+permissions: {}
+
+jobs:
+  check-headers:
+    name: Check headers
+    runs-on: ubuntu-20.04
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+        with:

Review Comment:
   Is this still necessary given that the header check is now moved outside of `validatePullRequest` and being done automatically on each PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org