You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "walterddr (via GitHub)" <gi...@apache.org> on 2023/06/16 14:14:43 UTC

[GitHub] [pinot] walterddr commented on a diff in pull request #10930: [multistage] Do Not Log Entire Plan in QueryServer

walterddr commented on code in PR #10930:
URL: https://github.com/apache/pinot/pull/10930#discussion_r1232312062


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryServer.java:
##########
@@ -100,7 +100,7 @@ public void submit(Worker.QueryRequest request, StreamObserver<Worker.QueryRespo
     try {
       distributedStagePlans = QueryPlanSerDeUtils.deserializeStagePlan(request);
     } catch (Exception e) {
-      LOGGER.error("Caught exception while deserializing the request: {}, payload: {}", requestId, request, e);
+      LOGGER.error("Caught exception while deserializing the request: {}", requestId, e);

Review Comment:
   this only applies to a single stage of error that occurs during deserializing yes? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org