You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2018/03/19 14:24:46 UTC
Re: Review Request 66135: RANGER-2030: UI updates to accommodate
policy effective dates
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66135/
-----------------------------------------------------------
(Updated March 19, 2018, 2:24 p.m.)
Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
Summary (updated)
-----------------
RANGER-2030: UI updates to accommodate policy effective dates
Bugs: RANGER-2030
https://issues.apache.org/jira/browse/RANGER-2030
Repository: ranger
Description
-------
Policy screens should support effective dates(i.e policy start time, end time and timezone).
Diffs
-----
security-admin/src/main/webapp/index.html d8a5d98
security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/css/bootstrap-datetimepicker.min.css PRE-CREATION
security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/js/bootstrap-datetimepicker.min.js PRE-CREATION
security-admin/src/main/webapp/scripts/Init.js c388a79
security-admin/src/main/webapp/scripts/models/RangerPolicy.js b1fb143
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8afc2e6
security-admin/src/main/webapp/scripts/utils/XAGlobals.js d55ab4a
security-admin/src/main/webapp/scripts/utils/XAUtils.js c1e6ef5
security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 4b15ab7
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 04dad2e
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js fa7f191
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js f23d18c
security-admin/src/main/webapp/styles/xa.css 9eb99d9
security-admin/src/main/webapp/templates/helpers/XAHelpers.js 946b6a3
security-admin/src/main/webapp/templates/policies/PolicyTimeItem_tmpl.html PRE-CREATION
security-admin/src/main/webapp/templates/policies/PolicyTimeList_tmpl.html PRE-CREATION
security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html 78a56c6
security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 859aced
security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 6d2eb3f
Diff: https://reviews.apache.org/r/66135/diff/1/
Testing
-------
1.Able to create policy by adding start date, end date and timezone.
2.Able to create a policy with multiple validity time
3.Also tested Policy CRUD.
4.Checked policy enforcement for time-based /normal policy.
Thanks,
Nitin Galave
Re: Review Request 66135: RANGER-2030: UI updates to accommodate
policy effective dates
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66135/#review199502
-----------------------------------------------------------
Fix it, then Ship it!
security-admin/src/main/webapp/index.html
Line 39 (original), 39 (patched)
<https://reviews.apache.org/r/66135/#comment279806>
Please correct the comment to reflect the right JIRA.
- Velmurugan Periasamy
On March 19, 2018, 2:24 p.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66135/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 2:24 p.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2030
> https://issues.apache.org/jira/browse/RANGER-2030
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Policy screens should support effective dates(i.e policy start time, end time and timezone).
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/index.html d8a5d98
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/css/bootstrap-datetimepicker.min.css PRE-CREATION
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/js/bootstrap-datetimepicker.min.js PRE-CREATION
> security-admin/src/main/webapp/scripts/Init.js c388a79
> security-admin/src/main/webapp/scripts/models/RangerPolicy.js b1fb143
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8afc2e6
> security-admin/src/main/webapp/scripts/utils/XAGlobals.js d55ab4a
> security-admin/src/main/webapp/scripts/utils/XAUtils.js c1e6ef5
> security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 4b15ab7
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 04dad2e
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js fa7f191
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js f23d18c
> security-admin/src/main/webapp/styles/xa.css 9eb99d9
> security-admin/src/main/webapp/templates/helpers/XAHelpers.js 946b6a3
> security-admin/src/main/webapp/templates/policies/PolicyTimeItem_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/PolicyTimeList_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html 78a56c6
> security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 859aced
> security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 6d2eb3f
>
>
> Diff: https://reviews.apache.org/r/66135/diff/1/
>
>
> Testing
> -------
>
> 1.Able to create policy by adding start date, end date and timezone.
> 2.Able to create a policy with multiple validity time
> 3.Also tested Policy CRUD.
> 4.Checked policy enforcement for time-based /normal policy.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 66135: RANGER-2030: UI updates to accommodate
policy effective dates
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66135/#review199514
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On March 20, 2018, 4:19 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66135/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 4:19 a.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2030
> https://issues.apache.org/jira/browse/RANGER-2030
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Policy screens should support effective dates(i.e policy start time, end time and timezone).
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/index.html d8a5d98
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/css/bootstrap-datetimepicker.min.css PRE-CREATION
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/js/bootstrap-datetimepicker.min.js PRE-CREATION
> security-admin/src/main/webapp/scripts/Init.js c388a79
> security-admin/src/main/webapp/scripts/models/RangerPolicy.js b1fb143
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8afc2e6
> security-admin/src/main/webapp/scripts/utils/XAGlobals.js d55ab4a
> security-admin/src/main/webapp/scripts/utils/XAUtils.js c1e6ef5
> security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 4b15ab7
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 04dad2e
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js fa7f191
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js f23d18c
> security-admin/src/main/webapp/styles/xa.css 9eb99d9
> security-admin/src/main/webapp/templates/helpers/XAHelpers.js 946b6a3
> security-admin/src/main/webapp/templates/policies/PolicyTimeItem_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/PolicyTimeList_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html 78a56c6
> security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 859aced
> security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 6d2eb3f
>
>
> Diff: https://reviews.apache.org/r/66135/diff/2/
>
>
> Testing
> -------
>
> 1.Able to create policy by adding start date, end date and timezone.
> 2.Able to create a policy with multiple validity time
> 3.Also tested Policy CRUD.
> 4.Checked policy enforcement for time-based /normal policy.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 66135: RANGER-2030: UI updates to accommodate
policy effective dates
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66135/#review199537
-----------------------------------------------------------
Ship it!
Ship It!
- Gautam Borad
On March 20, 2018, 10:51 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66135/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 10:51 a.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2030
> https://issues.apache.org/jira/browse/RANGER-2030
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Policy screens should support effective dates(i.e policy start time, end time and timezone).
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/index.html d8a5d98
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/css/bootstrap-datetimepicker.min.css PRE-CREATION
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/js/bootstrap-datetimepicker.min.js PRE-CREATION
> security-admin/src/main/webapp/scripts/Init.js c388a79
> security-admin/src/main/webapp/scripts/models/RangerPolicy.js b1fb143
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8afc2e6
> security-admin/src/main/webapp/scripts/utils/XAGlobals.js d55ab4a
> security-admin/src/main/webapp/scripts/utils/XAUtils.js c1e6ef5
> security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 4b15ab7
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 04dad2e
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js fa7f191
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js f23d18c
> security-admin/src/main/webapp/styles/xa.css 9eb99d9
> security-admin/src/main/webapp/templates/helpers/XAHelpers.js 946b6a3
> security-admin/src/main/webapp/templates/policies/PolicyTimeItem_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/PolicyTimeList_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html 78a56c6
> security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 859aced
> security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 6d2eb3f
>
>
> Diff: https://reviews.apache.org/r/66135/diff/3/
>
>
> Testing
> -------
>
> 1.Able to create policy by adding start date, end date and timezone.
> 2.Able to create a policy with multiple validity time
> 3.Also tested Policy CRUD.
> 4.Checked policy enforcement for time-based /normal policy.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 66135: RANGER-2030: UI updates to accommodate
policy effective dates
Posted by Zsombor Gegesy <zs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66135/#review199536
-----------------------------------------------------------
Ship it!
Ship It!
- Zsombor Gegesy
On March 20, 2018, 10:51 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66135/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 10:51 a.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2030
> https://issues.apache.org/jira/browse/RANGER-2030
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Policy screens should support effective dates(i.e policy start time, end time and timezone).
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/index.html d8a5d98
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/css/bootstrap-datetimepicker.min.css PRE-CREATION
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/js/bootstrap-datetimepicker.min.js PRE-CREATION
> security-admin/src/main/webapp/scripts/Init.js c388a79
> security-admin/src/main/webapp/scripts/models/RangerPolicy.js b1fb143
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8afc2e6
> security-admin/src/main/webapp/scripts/utils/XAGlobals.js d55ab4a
> security-admin/src/main/webapp/scripts/utils/XAUtils.js c1e6ef5
> security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 4b15ab7
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 04dad2e
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js fa7f191
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js f23d18c
> security-admin/src/main/webapp/styles/xa.css 9eb99d9
> security-admin/src/main/webapp/templates/helpers/XAHelpers.js 946b6a3
> security-admin/src/main/webapp/templates/policies/PolicyTimeItem_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/PolicyTimeList_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html 78a56c6
> security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 859aced
> security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 6d2eb3f
>
>
> Diff: https://reviews.apache.org/r/66135/diff/3/
>
>
> Testing
> -------
>
> 1.Able to create policy by adding start date, end date and timezone.
> 2.Able to create a policy with multiple validity time
> 3.Also tested Policy CRUD.
> 4.Checked policy enforcement for time-based /normal policy.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 66135: RANGER-2030: UI updates to accommodate
policy effective dates
Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66135/
-----------------------------------------------------------
(Updated March 20, 2018, 10:51 a.m.)
Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
Bugs: RANGER-2030
https://issues.apache.org/jira/browse/RANGER-2030
Repository: ranger
Description
-------
Policy screens should support effective dates(i.e policy start time, end time and timezone).
Diffs (updated)
-----
security-admin/src/main/webapp/index.html d8a5d98
security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/css/bootstrap-datetimepicker.min.css PRE-CREATION
security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/js/bootstrap-datetimepicker.min.js PRE-CREATION
security-admin/src/main/webapp/scripts/Init.js c388a79
security-admin/src/main/webapp/scripts/models/RangerPolicy.js b1fb143
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8afc2e6
security-admin/src/main/webapp/scripts/utils/XAGlobals.js d55ab4a
security-admin/src/main/webapp/scripts/utils/XAUtils.js c1e6ef5
security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 4b15ab7
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 04dad2e
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js fa7f191
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js f23d18c
security-admin/src/main/webapp/styles/xa.css 9eb99d9
security-admin/src/main/webapp/templates/helpers/XAHelpers.js 946b6a3
security-admin/src/main/webapp/templates/policies/PolicyTimeItem_tmpl.html PRE-CREATION
security-admin/src/main/webapp/templates/policies/PolicyTimeList_tmpl.html PRE-CREATION
security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html 78a56c6
security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 859aced
security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 6d2eb3f
Diff: https://reviews.apache.org/r/66135/diff/3/
Changes: https://reviews.apache.org/r/66135/diff/2-3/
Testing
-------
1.Able to create policy by adding start date, end date and timezone.
2.Able to create a policy with multiple validity time
3.Also tested Policy CRUD.
4.Checked policy enforcement for time-based /normal policy.
Thanks,
Nitin Galave
Re: Review Request 66135: RANGER-2030: UI updates to accommodate
policy effective dates
Posted by Nitin Galave <ni...@gmail.com>.
> On March 20, 2018, 8:42 a.m., Zsombor Gegesy wrote:
> > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
> > Lines 212 (patched)
> > <https://reviews.apache.org/r/66135/diff/2/?file=1982901#file1982901line215>
> >
> > Why this is commented out? The two html fragment looks the same - except this commented out part
Becuase policy expired indication feature we are handling as part of another improvement patch.
- Nitin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66135/#review199528
-----------------------------------------------------------
On March 20, 2018, 10:51 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66135/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 10:51 a.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2030
> https://issues.apache.org/jira/browse/RANGER-2030
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Policy screens should support effective dates(i.e policy start time, end time and timezone).
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/index.html d8a5d98
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/css/bootstrap-datetimepicker.min.css PRE-CREATION
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/js/bootstrap-datetimepicker.min.js PRE-CREATION
> security-admin/src/main/webapp/scripts/Init.js c388a79
> security-admin/src/main/webapp/scripts/models/RangerPolicy.js b1fb143
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8afc2e6
> security-admin/src/main/webapp/scripts/utils/XAGlobals.js d55ab4a
> security-admin/src/main/webapp/scripts/utils/XAUtils.js c1e6ef5
> security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 4b15ab7
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 04dad2e
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js fa7f191
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js f23d18c
> security-admin/src/main/webapp/styles/xa.css 9eb99d9
> security-admin/src/main/webapp/templates/helpers/XAHelpers.js 946b6a3
> security-admin/src/main/webapp/templates/policies/PolicyTimeItem_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/PolicyTimeList_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html 78a56c6
> security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 859aced
> security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 6d2eb3f
>
>
> Diff: https://reviews.apache.org/r/66135/diff/3/
>
>
> Testing
> -------
>
> 1.Able to create policy by adding start date, end date and timezone.
> 2.Able to create a policy with multiple validity time
> 3.Also tested Policy CRUD.
> 4.Checked policy enforcement for time-based /normal policy.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 66135: RANGER-2030: UI updates to accommodate
policy effective dates
Posted by Zsombor Gegesy <zs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66135/#review199528
-----------------------------------------------------------
security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js
Lines 154 (patched)
<https://reviews.apache.org/r/66135/#comment279816>
I'm not native, but for me, 'later than' would be more understandable. Or, just please fix the typo: 'greate' -> 'greater'
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
Lines 212 (patched)
<https://reviews.apache.org/r/66135/#comment279817>
Why this is commented out? The two html fragment looks the same - except this commented out part
- Zsombor Gegesy
On March 20, 2018, 4:19 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66135/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 4:19 a.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2030
> https://issues.apache.org/jira/browse/RANGER-2030
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Policy screens should support effective dates(i.e policy start time, end time and timezone).
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/index.html d8a5d98
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/css/bootstrap-datetimepicker.min.css PRE-CREATION
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/js/bootstrap-datetimepicker.min.js PRE-CREATION
> security-admin/src/main/webapp/scripts/Init.js c388a79
> security-admin/src/main/webapp/scripts/models/RangerPolicy.js b1fb143
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8afc2e6
> security-admin/src/main/webapp/scripts/utils/XAGlobals.js d55ab4a
> security-admin/src/main/webapp/scripts/utils/XAUtils.js c1e6ef5
> security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 4b15ab7
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 04dad2e
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js fa7f191
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js f23d18c
> security-admin/src/main/webapp/styles/xa.css 9eb99d9
> security-admin/src/main/webapp/templates/helpers/XAHelpers.js 946b6a3
> security-admin/src/main/webapp/templates/policies/PolicyTimeItem_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/PolicyTimeList_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html 78a56c6
> security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 859aced
> security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 6d2eb3f
>
>
> Diff: https://reviews.apache.org/r/66135/diff/2/
>
>
> Testing
> -------
>
> 1.Able to create policy by adding start date, end date and timezone.
> 2.Able to create a policy with multiple validity time
> 3.Also tested Policy CRUD.
> 4.Checked policy enforcement for time-based /normal policy.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 66135: RANGER-2030: UI updates to accommodate
policy effective dates
Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66135/
-----------------------------------------------------------
(Updated March 20, 2018, 4:19 a.m.)
Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
Bugs: RANGER-2030
https://issues.apache.org/jira/browse/RANGER-2030
Repository: ranger
Description
-------
Policy screens should support effective dates(i.e policy start time, end time and timezone).
Diffs (updated)
-----
security-admin/src/main/webapp/index.html d8a5d98
security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/css/bootstrap-datetimepicker.min.css PRE-CREATION
security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/js/bootstrap-datetimepicker.min.js PRE-CREATION
security-admin/src/main/webapp/scripts/Init.js c388a79
security-admin/src/main/webapp/scripts/models/RangerPolicy.js b1fb143
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8afc2e6
security-admin/src/main/webapp/scripts/utils/XAGlobals.js d55ab4a
security-admin/src/main/webapp/scripts/utils/XAUtils.js c1e6ef5
security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 4b15ab7
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 04dad2e
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js fa7f191
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js f23d18c
security-admin/src/main/webapp/styles/xa.css 9eb99d9
security-admin/src/main/webapp/templates/helpers/XAHelpers.js 946b6a3
security-admin/src/main/webapp/templates/policies/PolicyTimeItem_tmpl.html PRE-CREATION
security-admin/src/main/webapp/templates/policies/PolicyTimeList_tmpl.html PRE-CREATION
security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html 78a56c6
security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 859aced
security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 6d2eb3f
Diff: https://reviews.apache.org/r/66135/diff/2/
Changes: https://reviews.apache.org/r/66135/diff/1-2/
Testing
-------
1.Able to create policy by adding start date, end date and timezone.
2.Able to create a policy with multiple validity time
3.Also tested Policy CRUD.
4.Checked policy enforcement for time-based /normal policy.
Thanks,
Nitin Galave