You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/20 13:56:19 UTC
[GitHub] [pulsar-helm-chart] MBcom opened a new pull request, #280: Make included prometheus server configurable
MBcom opened a new pull request, #280:
URL: https://github.com/apache/pulsar-helm-chart/pull/280
Fixes #278
### Motivation
We want to connect the included Prometheus server to an external Alert Manager which is currently not possible.
### Modifications
We have moved the hard coded configuration from `templates/prometheus-configmap.yaml` to `prometheus.configData` in `values.yaml`
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #280: Make included prometheus server configurable
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #280:
URL: https://github.com/apache/pulsar-helm-chart/pull/280#issuecomment-1281537830
Thank you for your contribution @MBcom! I am proposing that we use the `kube-prometheus-stack` to manage prometheus and grafana. I think this will fulfill the needs raised in this PR and in #278. If you agree, I think we can close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #280: Make included prometheus server configurable
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #280:
URL: https://github.com/apache/pulsar-helm-chart/pull/280#issuecomment-1284921677
Since we merged https://github.com/apache/pulsar-helm-chart/issues/278, the Prometheus server's configuration is now exposed, so I am going to close this PR. Please re-open it if you believe this is incorrect @MBcom. Thanks for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall closed pull request #280: Make included prometheus server configurable
Posted by GitBox <gi...@apache.org>.
michaeljmarshall closed pull request #280: Make included prometheus server configurable
URL: https://github.com/apache/pulsar-helm-chart/pull/280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org