You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/20 02:52:25 UTC
[GitHub] [pulsar] freeznet commented on a change in pull request #12625: [Sink] Fix the marshal and unmarshal the sink config
freeznet commented on a change in pull request #12625:
URL: https://github.com/apache/pulsar/pull/12625#discussion_r753624195
##########
File path: pulsar-functions/utils/src/test/java/org/apache/pulsar/functions/utils/SinkConfigUtilsTest.java
##########
@@ -46,15 +47,13 @@
import java.nio.file.Files;
import java.util.Collections;
import java.util.HashMap;
+import java.util.List;
import java.util.Map;
-import static org.apache.pulsar.common.functions.FunctionConfig.ProcessingGuarantees.EFFECTIVELY_ONCE;
+import static org.apache.pulsar.common.functions.FunctionConfig.ProcessingGuarantees.*;
Review comment:
please avoid star import
##########
File path: pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SinkConfigUtils.java
##########
@@ -278,18 +275,24 @@ public static SinkConfig convertFromDetails(FunctionDetails functionDetails) {
if (!isEmpty(functionDetails.getSource().getSubscriptionName())) {
sinkConfig.setSourceSubscriptionName(functionDetails.getSource().getSubscriptionName());
}
- if (functionDetails.getSource().getSubscriptionType() == Function.SubscriptionType.FAILOVER) {
- sinkConfig.setRetainOrdering(true);
- sinkConfig.setProcessingGuarantees(FunctionConfig.ProcessingGuarantees.EFFECTIVELY_ONCE);
- } else {
- sinkConfig.setRetainOrdering(false);
- sinkConfig.setProcessingGuarantees(FunctionConfig.ProcessingGuarantees.ATLEAST_ONCE);
+
+ switch (functionDetails.getSource().getSubscriptionType()) {
+ case SHARED:
+ sinkConfig.setRetainOrdering(false);
+ break;
+ case FAILOVER:
+ sinkConfig.setRetainOrdering(true);
+ break;
Review comment:
can we have a default case here?
##########
File path: pulsar-functions/utils/src/test/java/org/apache/pulsar/functions/utils/SinkConfigUtilsTest.java
##########
@@ -46,15 +47,13 @@
import java.nio.file.Files;
import java.util.Collections;
import java.util.HashMap;
+import java.util.List;
import java.util.Map;
-import static org.apache.pulsar.common.functions.FunctionConfig.ProcessingGuarantees.EFFECTIVELY_ONCE;
+import static org.apache.pulsar.common.functions.FunctionConfig.ProcessingGuarantees.*;
import static org.mockito.ArgumentMatchers.any;
import static org.powermock.api.mockito.PowerMockito.mockStatic;
-import static org.testng.Assert.assertEquals;
-import static org.testng.Assert.assertFalse;
-import static org.testng.Assert.assertTrue;
-import static org.testng.Assert.expectThrows;
+import static org.testng.Assert.*;
Review comment:
please avoid star import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org