You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/09/18 14:17:56 UTC

[GitHub] [storm] Ethanlm commented on pull request #3337: [STORM-3702] Change thrift exception classes to contain getMessage() method

Ethanlm commented on pull request #3337:
URL: https://github.com/apache/storm/pull/3337#issuecomment-694895679


   Since it is possible to break backwards compatibility, I am more conservative on this and would like more tests to be done.
   
   (1) Did we get a chance to test with old clients? 
   (2) And did we get a chance to test python code (client and topology code written in python) since this PR added storm_exception.py? 
   (3) Will it break backwards compatibility for server-side plugins if they invoke old `get_msg` method? 
   (4) Or is it possible that some of the topology code invokes some "exception.get_msg" method in bolt/spout, and when the topology code runs on the upgraded cluster, throwing NoSuchMethod error?
   
   For (3-4), my question is more like: if there is any case like these cases. I am currently not sure.
   
   Thanks
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org