You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/31 16:50:07 UTC
[GitHub] [airflow] potiuk opened a new pull request #22660: Make sure build-prod-image works in the new Breeze2
potiuk opened a new pull request #22660:
URL: https://github.com/apache/airflow/pull/22660
Some defaults were missing for manual build of PROD images.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22660: Make sure build-prod-image works in the new Breeze2
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22660:
URL: https://github.com/apache/airflow/pull/22660#issuecomment-1084838248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #22660: Make sure build-prod-image works in the new Breeze2
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #22660:
URL: https://github.com/apache/airflow/pull/22660#discussion_r840552222
##########
File path: dev/breeze/src/airflow_breeze/prod/prod_params.py
##########
@@ -47,10 +47,10 @@ class ProdParams:
install_docker_context_files: bool
disable_pypi_when_building: bool
disable_pip_cache: bool
- upgrade_to_newer_dependencies: str
- skip_installing_airflow_providers_from_sources: bool
- cleanup_docker_context_files: bool
- prepare_buildx_cache: bool
+ upgrade_to_newer_dependencies: str = "false"
+ skip_installing_airflow_providers_from_sources: bool = False
Review comment:
Ah no - it's already merged and fixed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #22660: Make sure build-prod-image works in the new Breeze2
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #22660:
URL: https://github.com/apache/airflow/pull/22660#discussion_r840434624
##########
File path: dev/breeze/src/airflow_breeze/prod/prod_params.py
##########
@@ -47,10 +47,10 @@ class ProdParams:
install_docker_context_files: bool
disable_pypi_when_building: bool
disable_pip_cache: bool
- upgrade_to_newer_dependencies: str
- skip_installing_airflow_providers_from_sources: bool
- cleanup_docker_context_files: bool
- prepare_buildx_cache: bool
+ upgrade_to_newer_dependencies: str = "false"
+ skip_installing_airflow_providers_from_sources: bool = False
Review comment:
It was failing without it when I manually run it at least `./Breeze2 build-prod-image` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #22660: Make sure build-prod-image works in the new Breeze2
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #22660:
URL: https://github.com/apache/airflow/pull/22660#discussion_r840434624
##########
File path: dev/breeze/src/airflow_breeze/prod/prod_params.py
##########
@@ -47,10 +47,10 @@ class ProdParams:
install_docker_context_files: bool
disable_pypi_when_building: bool
disable_pip_cache: bool
- upgrade_to_newer_dependencies: str
- skip_installing_airflow_providers_from_sources: bool
- cleanup_docker_context_files: bool
- prepare_buildx_cache: bool
+ upgrade_to_newer_dependencies: str = "false"
+ skip_installing_airflow_providers_from_sources: bool = False
Review comment:
It was failing when I manually run it at least `./Breeze2 build-prod-image` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on a change in pull request #22660: Make sure build-prod-image works in the new Breeze2
Posted by GitBox <gi...@apache.org>.
Bowrna commented on a change in pull request #22660:
URL: https://github.com/apache/airflow/pull/22660#discussion_r840326564
##########
File path: dev/breeze/src/airflow_breeze/prod/prod_params.py
##########
@@ -47,10 +47,10 @@ class ProdParams:
install_docker_context_files: bool
disable_pypi_when_building: bool
disable_pip_cache: bool
- upgrade_to_newer_dependencies: str
- skip_installing_airflow_providers_from_sources: bool
- cleanup_docker_context_files: bool
- prepare_buildx_cache: bool
+ upgrade_to_newer_dependencies: str = "false"
+ skip_installing_airflow_providers_from_sources: bool = False
Review comment:
@potiuk `skip_installing_airflow_providers_from_sources`, `cleanup_docker_context_files`, ` prepare_buildx_cache`. Do we have to keep these flags `False` by default? Because when user doesn't pass them it will be False and that's why i didn't keep it default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22660: Make sure build-prod-image works in the new Breeze2
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22660:
URL: https://github.com/apache/airflow/pull/22660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on a change in pull request #22660: Make sure build-prod-image works in the new Breeze2
Posted by GitBox <gi...@apache.org>.
Bowrna commented on a change in pull request #22660:
URL: https://github.com/apache/airflow/pull/22660#discussion_r840514786
##########
File path: dev/breeze/src/airflow_breeze/prod/prod_params.py
##########
@@ -47,10 +47,10 @@ class ProdParams:
install_docker_context_files: bool
disable_pypi_when_building: bool
disable_pip_cache: bool
- upgrade_to_newer_dependencies: str
- skip_installing_airflow_providers_from_sources: bool
- cleanup_docker_context_files: bool
- prepare_buildx_cache: bool
+ upgrade_to_newer_dependencies: str = "false"
+ skip_installing_airflow_providers_from_sources: bool = False
Review comment:
Oh i see. It's working fine for me. I have checked again and it's working. Could you check once again and let me know? if it throws error, i will fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org