You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mrunit.apache.org by "Brock Noland (Created) (JIRA)" <ji...@apache.org> on 2012/01/18 21:02:39 UTC
[jira] [Created] (MRUNIT-54) Driver.runTest throws
RunetimeException should it throw AssertionError
Driver.runTest throws RunetimeException should it throw AssertionError
----------------------------------------------------------------------
Key: MRUNIT-54
URL: https://issues.apache.org/jira/browse/MRUNIT-54
Project: MRUnit
Issue Type: Bug
Reporter: Brock Noland
The difference is small but in maven tests show up as erred not failed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-54) Driver.runTest throws
RuntimeException should it throw AssertionError?
Posted by "Jim Donofrio (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225852#comment-13225852 ]
Jim Donofrio commented on MRUNIT-54:
------------------------------------
committed in 1298706
> Driver.runTest throws RuntimeException should it throw AssertionError?
> ----------------------------------------------------------------------
>
> Key: MRUNIT-54
> URL: https://issues.apache.org/jira/browse/MRUNIT-54
> Project: MRUnit
> Issue Type: Bug
> Reporter: Brock Noland
> Assignee: Jim Donofrio
> Fix For: 1.0.0
>
>
> The difference is small but in maven tests show up as erred not failed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-54) Driver.runTest throws
RuntimeException should it throw AssertionError?
Posted by "Jim Donofrio (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220657#comment-13220657 ]
Jim Donofrio commented on MRUNIT-54:
------------------------------------
Can we change this?
> Driver.runTest throws RuntimeException should it throw AssertionError?
> ----------------------------------------------------------------------
>
> Key: MRUNIT-54
> URL: https://issues.apache.org/jira/browse/MRUNIT-54
> Project: MRUnit
> Issue Type: Bug
> Reporter: Brock Noland
>
> The difference is small but in maven tests show up as erred not failed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-54) Driver.runTest throws
RuntimeException should it throw AssertionError?
Posted by "Jim Donofrio (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216862#comment-13216862 ]
Jim Donofrio commented on MRUNIT-54:
------------------------------------
Yes I agree we should change all test assert failures to throw AssertionError instead of mixing IOException and assert failures as RuntimeExceptions
We just have to change throw new RuntimeException(buffer.toString()); to fail(buffer.toString()); in TestDriver and update the test to catch AssertionError
> Driver.runTest throws RuntimeException should it throw AssertionError?
> ----------------------------------------------------------------------
>
> Key: MRUNIT-54
> URL: https://issues.apache.org/jira/browse/MRUNIT-54
> Project: MRUnit
> Issue Type: Bug
> Reporter: Brock Noland
>
> The difference is small but in maven tests show up as erred not failed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-54) Driver.runTest throws
RuntimeException should it throw AssertionError?
Posted by "Jarek Jarcec Cecho (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217076#comment-13217076 ]
Jarek Jarcec Cecho commented on MRUNIT-54:
------------------------------------------
+1 (I also agree that it would make more sense to use AssertionError rather than IOException or RuntimeException)
> Driver.runTest throws RuntimeException should it throw AssertionError?
> ----------------------------------------------------------------------
>
> Key: MRUNIT-54
> URL: https://issues.apache.org/jira/browse/MRUNIT-54
> Project: MRUnit
> Issue Type: Bug
> Reporter: Brock Noland
>
> The difference is small but in maven tests show up as erred not failed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MRUNIT-54) Driver.runTest throws
RuntimeException should it throw AssertionError?
Posted by "Jim Donofrio (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Donofrio resolved MRUNIT-54.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.0.0
Changed validate to use JUnit fail method instead of throws RuntimeException
Removed throws RuntimeException on runTests methods
added ExpectedSuppliedException class to better test exceptions
fixed test methods to use ExpectedSuppliedException to test for AssertionError along with correct message in the exception
> Driver.runTest throws RuntimeException should it throw AssertionError?
> ----------------------------------------------------------------------
>
> Key: MRUNIT-54
> URL: https://issues.apache.org/jira/browse/MRUNIT-54
> Project: MRUnit
> Issue Type: Bug
> Reporter: Brock Noland
> Assignee: Jim Donofrio
> Fix For: 1.0.0
>
>
> The difference is small but in maven tests show up as erred not failed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-54) Driver.runTest throws
RuntimeException should it throw AssertionError?
Posted by "Brock Noland (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223014#comment-13223014 ]
Brock Noland commented on MRUNIT-54:
------------------------------------
Sounds good!
> Driver.runTest throws RuntimeException should it throw AssertionError?
> ----------------------------------------------------------------------
>
> Key: MRUNIT-54
> URL: https://issues.apache.org/jira/browse/MRUNIT-54
> Project: MRUnit
> Issue Type: Bug
> Reporter: Brock Noland
> Assignee: Jim Donofrio
>
> The difference is small but in maven tests show up as erred not failed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MRUNIT-54) Driver.runTest throws RuntimeException
should it throw AssertionError?
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated MRUNIT-54:
-------------------------------
Summary: Driver.runTest throws RuntimeException should it throw AssertionError? (was: Driver.runTest throws RunetimeException should it throw AssertionError)
> Driver.runTest throws RuntimeException should it throw AssertionError?
> ----------------------------------------------------------------------
>
> Key: MRUNIT-54
> URL: https://issues.apache.org/jira/browse/MRUNIT-54
> Project: MRUnit
> Issue Type: Bug
> Reporter: Brock Noland
>
> The difference is small but in maven tests show up as erred not failed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MRUNIT-54) Driver.runTest throws
RuntimeException should it throw AssertionError?
Posted by "Jim Donofrio (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Donofrio reassigned MRUNIT-54:
----------------------------------
Assignee: Jim Donofrio
> Driver.runTest throws RuntimeException should it throw AssertionError?
> ----------------------------------------------------------------------
>
> Key: MRUNIT-54
> URL: https://issues.apache.org/jira/browse/MRUNIT-54
> Project: MRUnit
> Issue Type: Bug
> Reporter: Brock Noland
> Assignee: Jim Donofrio
>
> The difference is small but in maven tests show up as erred not failed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-54) Driver.runTest throws
RuntimeException should it throw AssertionError?
Posted by "Jim Donofrio (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222951#comment-13222951 ]
Jim Donofrio commented on MRUNIT-54:
------------------------------------
I am going to make this change, 3 of us are in agreement and no users have responded on mrunit-user since you sent the email 2 week ago on Feb 27
> Driver.runTest throws RuntimeException should it throw AssertionError?
> ----------------------------------------------------------------------
>
> Key: MRUNIT-54
> URL: https://issues.apache.org/jira/browse/MRUNIT-54
> Project: MRUnit
> Issue Type: Bug
> Reporter: Brock Noland
>
> The difference is small but in maven tests show up as erred not failed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira