[jira] [Commented] (PHOENIX-2945) Fix SortOrderExpressionTest.toChar on non-English locales

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303525#comment-15303525 ] 

Hadoop QA commented on PHOENIX-2945:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12806561/PHOENIX-2945.patch
  against master branch at commit c2bb3c38e73a34f2097e6dd07eff388a22149bbc.
  ATTACHMENT ID: 12806561

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 31 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 4 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +            List<Expression> args = Lists.newArrayList(getInvertedLiteral(date(12, 11, 2001), PDate.INSTANCE));
+            evaluateAndAssertResult(new ToCharFunction(args, FunctionArgumentType.TEMPORAL, "", DateUtil.getDateFormatter("MM/dd/yy hh:mm a")), "12/11/01 12:00 AM");

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/367//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/367//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/367//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/367//console

This message is automatically generated.

> Fix SortOrderExpressionTest.toChar on non-English locales
> ---------------------------------------------------------
>
>                 Key: PHOENIX-2945
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2945
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Junegunn Choi
>            Assignee: Junegunn Choi
>            Priority: Minor
>         Attachments: PHOENIX-2945.patch
>
>
> {{SortOrderExpressionTest.toChar}} fails on non-English locales due to different representations of "AM".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)