You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Vladimir Prus <gh...@cs.msu.su> on 2002/11/05 11:36:44 UTC

svn up -p

Hello,
I'm now looking at issue 399 (need 'svn up -p' feature) with
intention of implementing it someday before 1.0, provided this
feature is considered usefull (I find it so).

I belive that the only reasonable use of "svn up -p" would be
getting a specific revision of one file: running it on several
files or a directory has no point. So, I see three ways of
implementing it:

1. Change existing update editor so that it checks a specially added
    field in editor button.
2. Write a new editor which would have only a couple of
    meaningfull methods.
3. Don't bother, and use get_file from RA level.

I think that 3) is the simplest approach and is quite OK. Even if
fulltext will be send, who cares for one file?

So, what are opinions?

- Volodya



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn up -p

Posted by Greg Stein <gs...@lyra.org>.
On Tue, Nov 05, 2002 at 06:58:47AM -0600, Ben Collins-Sussman wrote:
> Vladimir Prus <gh...@cs.msu.su> writes:
> 
> > 3. Don't bother, and use get_file from RA level.
>...
> Besides, I recall gstein mentioning that someday RA->get_file() will
> someday be able to tell the server what version you already have, so
> it can get a true svndiff back instead of a fulltext.

Well, it can get an svndiff today, but it returns that svndiff to the caller
(wrong!), rather than combining it with the local fulltext to produce the
new fulltext.

Right now, we use the RA callbacks to determine a fulltext is present (by
asking for the version URL property which corresponds to that fulltext). We
need to expand the callbacks to say "give me the fulltext that you said you
already had." When we have that callback, then we can combine the fulltext
and diff to produce a new fulltext to return to the get_file caller.

Today, we disable get_file's fetching of svndiff's by disabling the fetch of
the version URL property.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn up -p

Posted by Nuutti Kotivuori <na...@iki.fi>.
Karl Fogel wrote:
> Vladimir Prus <gh...@cs.msu.su> writes:
>> > And don't call the option "-p". Short options are in short supply
>> > :-), and I don't suppose this usage is common enough to warrant
>> > :one.
>> 
>> Actually, I've almost implemented this, and yes, I did not use "-p"
>> option.  It's "--print-only".
> 
> I believe the "-p" in CVS stood for "pipe", as in "pipe to stdout".
> Something involving "pipe" might be better; if you use
> "--print-only", people are going to think it has something to do
> with their printer.

I think the important word here is 'stdout', not pipe. People need to
realize that the file comes out of the standard output.

But that's just me :-)

-- Naked


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn up -p

Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Vladimir Prus <gh...@cs.msu.su> writes:
> > And don't call the option "-p". Short options are in short supply
> > :-), and I don't suppose this usage is common enough to warrant one.
> 
> Actually, I've almost implemented this, and yes, I did not use "-p" option.
> It's "--print-only".

I believe the "-p" in CVS stood for "pipe", as in "pipe to stdout".
Something involving "pipe" might be better; if you use "--print-only",
people are going to think it has something to do with their printer.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn up -p

Posted by Vladimir Prus <gh...@cs.msu.su>.
Branko Čibej wrote:
> Ben Collins-Sussman wrote:
> 
>> Vladimir Prus <gh...@cs.msu.su> writes:
>>
>>  
>>
>>> 3. Don't bother, and use get_file from RA level.
>>>
>>> I think that 3) is the simplest approach and is quite OK. Even if
>>> fulltext will be send, who cares for one file?
>>>   
>>
>>
>> I agree, #3 is probably the best method. 
>> Just make sure that 'svn up -p' is documented to work on a single
>> file, then.
>>
> And don't call the option "-p". Short options are in short supply :-), 
> and I don't suppose this usage is common enough to warrant one.

Actually, I've almost implemented this, and yes, I did not use "-p" option.
It's "--print-only".

- Volodya


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn up -p

Posted by Branko Čibej <br...@xbc.nu>.
Ben Collins-Sussman wrote:

>Vladimir Prus <gh...@cs.msu.su> writes:
>
>  
>
>>3. Don't bother, and use get_file from RA level.
>>
>>I think that 3) is the simplest approach and is quite OK. Even if
>>fulltext will be send, who cares for one file?
>>    
>>
>
>I agree, #3 is probably the best method.  
>
>Just make sure that 'svn up -p' is documented to work on a single
>file, then.
>
And don't call the option "-p". Short options are in short supply :-), 
and I don't suppose this usage is common enough to warrant one.

    Brane


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn up -p

Posted by Ben Collins-Sussman <su...@collab.net>.
Vladimir Prus <gh...@cs.msu.su> writes:

> 3. Don't bother, and use get_file from RA level.
> 
> I think that 3) is the simplest approach and is quite OK. Even if
> fulltext will be send, who cares for one file?

I agree, #3 is probably the best method.  

Just make sure that 'svn up -p' is documented to work on a single
file, then.

Besides, I recall gstein mentioning that someday RA->get_file() will
someday be able to tell the server what version you already have, so
it can get a true svndiff back instead of a fulltext.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org