[GitHub] andrewfayres opened a new pull request #12883: NativeResource Management in Scala (#12647)

[GitBox <gi...@apache.org>]

andrewfayres opened a new pull request #12883: NativeResource Management in Scala (#12647)
URL: https://github.com/apache/incubator-mxnet/pull/12883
 
 
   * add Generic MXNetHandle trait and MXNetHandlePhantomRef class that will be used by all MXNetObjects
   
   * Generic Handle with AutoCloseable
   
   * add NativeResource and NativeResourceManager with Periodic GC calling
   
   * use NativeResource trait in NDArray, Symbol and Executor
   
   * add run train mnist script
   
   * create a Generic ResourceScope that can collect all NativeResources to dispose at the end
   
   * modify NativeResource and ResourceScope, extend NativeResource in NDArray, Symbol and Executor
   
   * remove GCExecutor
   
   * deRegister PhantomReferences by when calling dispose()
   
   * add Finalizer(temporary) to NativeResource
   
   * refactor NativeResource.dispose() method
   
   * update NativeResource/add Unit Test for NativeResource
   
   * updates to NativeResource/NativeResourceRef and unit tests to NativeResource
   
   * remove redundant code added because of the object equality that was needed
   
   * add ResourceScope
   
   * Fix NativeResource to not remove from Scope, add Unit Tests to ResourceScope
   
   * cleanup log/print debug statements
   
   * use TreeSet inplace of ArrayBuffer to speedup removal of resources from ResourceScope
   Fix Executor dispose and make KVStore a NativeResource
   
   * fix segfault that was happening because of NDArray creation on the fly in Optimizer
   
   * Add comments for dispose(param:Boolean)
   
   ## Description ##
   (Brief description on what this PR is about)
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services