You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@royale.apache.org by Serkan Taş <se...@likyateknoloji.com> on 2019/09/16 15:10:46 UTC

XML declaration warning

Hi,

While declaring xml in mxml, I am getting warning from the compiler for 
case 1, and fixed with case 2. I thought  someone may need to know.

case1 :

private function refreshSelect(data:XML):void {
                 var xml:XML = <mydata id="" />
                 xml.@id = data;
                 jobTree.refreshTree(xml);
}

converted to :

com.likya.pinara.main.PinaraUI.prototype.com_likya_pinara_main_PinaraUI_refreshSelect 
= function(data) {
   var /** @type {XML} */ xml = new XML( '<mydata id="" />\r\
\t\t\t\t');
   xml.setAttribute('id', data);
   this.jobTree.refreshTree(xml);
};

warning :

Sep 16, 2019 6:09:36 PM com.google.javascript.jscomp.LoggerErrorManager 
println
WARNING: 
D:/dev/royale-emulation-works/github/bin/js-debug/com/likya/pinara/main/PinaraUI.js:367: 
WARNING - String continuations are not recommended. See 
https://google.github.io/styleguide/jsguide.html#features-strings-no-line-continuations
   var /** @type {XML} */ xml = new XML( '<mydata id="" />\r\
                                         ^


case2 :
private function refreshSelect(data:XML):void {
                 var xml:XML = <mydata id="" />*;*
                 xml.@id = data;
                 jobTree.refreshTree(xml);
  }


converted to :


com.likya.pinara.main.PinaraUI.prototype.com_likya_pinara_main_PinaraUI_refreshSelect 
= function(data) {
   var /** @type {XML} */ xml = new XML( '<mydata id="" />');
   xml.setAttribute('id', data);
   this.jobTree.refreshTree(xml);
};

No warning.

Re: XML declaration warning

Posted by Serkan Taş <se...@likyateknoloji.com>.
Sure,

Here it is : https://github.com/apache/royale-asjs/issues/470

Thanks

16.09.2019 19:34 tarihinde Alex Harui yazdı:
> No warning.

Re: XML declaration warning

Posted by Alex Harui <ah...@adobe.com>.
It would be great if you could file a GitHub issue to track this.

Thanks,
-Alex

From: Serkan Taş <se...@likyateknoloji.com>
Reply-To: "users@royale.apache.org" <us...@royale.apache.org>
Date: Monday, September 16, 2019 at 8:11 AM
To: "users@royale.apache.org" <us...@royale.apache.org>
Subject: XML declaration warning

Hi,

While declaring xml in mxml, I am getting warning from the compiler for case 1, and fixed with case 2. I thought  someone may need to know.

case1 :

private function refreshSelect(data:XML):void {
                var xml:XML = <mydata id="" />
                xml.@id = data;
                jobTree.refreshTree(xml);
}

converted to :

com.likya.pinara.main.PinaraUI.prototype.com_likya_pinara_main_PinaraUI_refreshSelect = function(data) {
  var /** @type {XML} */ xml = new XML( '<mydata id="" />\r\
\t\t\t\t');
  xml.setAttribute('id', data);
  this.jobTree.refreshTree(xml);
};

warning :

Sep 16, 2019 6:09:36 PM com.google.javascript.jscomp.LoggerErrorManager println
WARNING: D:/dev/royale-emulation-works/github/bin/js-debug/com/likya/pinara/main/PinaraUI.js:367: WARNING - String continuations are not recommended. See https://google.github.io/styleguide/jsguide.html#features-strings-no-line-continuations<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgoogle.github.io%2Fstyleguide%2Fjsguide.html%23features-strings-no-line-continuations&data=02%7C01%7Caharui%40adobe.com%7C241b78a8e3a047bbf73208d73ab8225e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637042434851629507&sdata=qEVh0Xife1dEMNXjZ4gQEthxqbGLW1GXWZ%2FFwm8yc7s%3D&reserved=0>
  var /** @type {XML} */ xml = new XML( '<mydata id="" />\r\
                                        ^


case2 :
private function refreshSelect(data:XML):void {
                var xml:XML = <mydata id="" />;
                xml.@id = data;
                jobTree.refreshTree(xml);
 }


converted to :


com.likya.pinara.main.PinaraUI.prototype.com_likya_pinara_main_PinaraUI_refreshSelect = function(data) {
  var /** @type {XML} */ xml = new XML( '<mydata id="" />');
  xml.setAttribute('id', data);
  this.jobTree.refreshTree(xml);
};

No warning.