You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by kayousterhout <gi...@git.apache.org> on 2016/06/15 00:57:53 UTC
[GitHub] spark pull request #13677: [SPARK 15926] Improve readability of DAGScheduler...
GitHub user kayousterhout opened a pull request:
https://github.com/apache/spark/pull/13677
[SPARK 15926] Improve readability of DAGScheduler stage creation methods
## What changes were proposed in this pull request?
This pull request refactors parts of the DAGScheduler to improve readability, focusing on the code around stage creation. One goal of this change it to make it clearer which functions may create new stages (as opposed to looking up stages that already exist). There are no functionality changes in this pull request. In more detail:
* shuffleToMapStage was renamed to shuffleIdToMapStage (when reading the existing code I have sometimes struggled to remember what the key is -- is it a stage? A stage id? This change is intended to avoid that confusion)
* Cleaned up the code to create shuffle map stages. Previously, creating a shuffle map stage involved 3 different functions (newOrUsedShuffleStage, newShuffleMapStage, and getShuffleMapStage), and it wasn't clear what the purpose of each function was. With the new code, a single function (getOrCreateShuffleMapStage) is responsible for getting a stage (if it already exists) or creating new shuffle map stages and any missing ancestor stages, and it delegates to createShuffleMapStage when new stages need to be created. There's some remaining confusion here because the getOrCreateParentStages call in createShuffleMapStage may recursively create ancestor stages; this is an issue I plan to fix in a future pull request, because it's trickier to fix and involves a slight functionality change.
* newResultStage was renamed to createResultStage, for consistency with naming around shuffle map stages.
* getParentStages has been renamed to getOrCreateParentStages, to make it clear that this function will sometimes create missing ancestor stages.
* The only *slight* functionality change is that on line 478, updateJobIdStageIdMaps now uses a stage's parents instance variable rather than re-calculating them (I couldn't see any reason why they'd need to be re-calculated, and suspect this is just leftover from older code).
* getAncestorShuffleDependencies was renamed to getMissingAncestorShuffleDependencies, to make it clear that this only returns dependencies that have not yet been run.
cc @squito @markhamstra @JoshRosen (who requested more DAG scheduler commenting long ago -- an issue this pull request tries, in part, to address)
FYI @rxin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kayousterhout/spark-1 SPARK-15926
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13677.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13677
----
commit 4dca8001cd987016fd683988632337ec64b67444
Author: Kay Ousterhout <ka...@gmail.com>
Date: 2016-06-15T00:34:50Z
Renamed shuffleToMapStaqe in DAGScheduler.
This commit renames shuffleToMapStage to shuffleIdToMapStage to make
it clear that the shuffle id (and not the shuffle dependency, or the
shuffle map stage, or the shuffle map stage id) is the key in the
hash map.
commit 1468b91cc3ca493bc18e16525fe39444616f2bb2
Author: Kay Ousterhout <ka...@gmail.com>
Date: 2016-06-10T21:17:10Z
Cleaned up the code to create new shuffle map stages
commit a1a51ac8be0e5c22917464e2e9389fe33351f0b0
Author: Kay Ousterhout <ka...@gmail.com>
Date: 2016-06-10T23:10:12Z
Various comment and naming cleanups
commit 671d5de33c21dc279e6dda83dfa8366b8adf6f9c
Author: Kay Ousterhout <ka...@gmail.com>
Date: 2016-06-11T00:22:59Z
More cleanup of shuffle map stage creation
commit 43841a7350af38551e9c349ab2f22c7e7e0a444d
Author: Kay Ousterhout <ka...@gmail.com>
Date: 2016-06-13T19:38:07Z
Some more naming and commenting improvements
commit 49156f245baab7282575fe422f8e10906b571958
Author: Kay Ousterhout <ka...@gmail.com>
Date: 2016-06-15T00:42:04Z
Moved createShuffleMapStage to be a non-nested function.
I think having it nested made the code harder to read.
commit 1b7a3386fb631f1a41ea73d6bfdc9961ed8e4234
Author: Kay Ousterhout <ka...@gmail.com>
Date: 2016-06-15T00:48:37Z
Renamed newResultStage to createResultStage and added commenting
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13677
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by markhamstra <gi...@git.apache.org>.
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/13677
LGTM, and runs without flakiness for me when rebased onto master with the https://github.com/apache/spark/pull/13688 HOTFIX.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13677: [SPARK-15926] Improve readability of DAGScheduler...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13677
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by markhamstra <gi...@git.apache.org>.
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/13677
> One goal of this change it to make it clearer which functions may create new stages (as opposed to looking up stages that already exist).
Something that I have been looking at of late, and I know that @squito has looked at some, too. In short, I'm pretty confident that we doing some silliness around creating new stages instead of reusing already existing stages, then recognizing that all the task for the "new" stages are already completed (at least we're smart enough to reuse the map outputs), so the "new" stages just become "skipped".
I'll take a closer look at this tomorrow, and may have a follow-on PR in the not too distant future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by squito <gi...@git.apache.org>.
Github user squito commented on the issue:
https://github.com/apache/spark/pull/13677
everything proposed here makes sense to me, I think just needs the one minor reordering I mentioned.
about creating extra stages, I looked into this some here: https://issues.apache.org/jira/browse/SPARK-10193. Actually seems fairly straight-forward, though I never followed up on profiling the extra memory involved. (happy to let someone else takeover, I doubt I'll get back to it anytime soon ...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13677
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60540/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13677
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13677
**[Test build #60714 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60714/consoleFull)** for PR 13677 at commit [`22c6e42`](https://github.com/apache/spark/commit/22c6e4204bf102c001871e3763207f146717f517).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13677
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60580/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13677
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60714/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13677
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13677
**[Test build #60580 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60580/consoleFull)** for PR 13677 at commit [`22c6e42`](https://github.com/apache/spark/commit/22c6e4204bf102c001871e3763207f146717f517).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by kayousterhout <gi...@git.apache.org>.
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/13677
Thanks for pointing out the re-ordering issue! Fixed.
Re: creating extra stages, I agree we could do better with that, because it is confusing. I have another commit with some *light* cleanup of that (but wanted to keep refactoring separate from functionality changes).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13677: [SPARK 15926] Improve readability of DAGScheduler...
Posted by squito <gi...@git.apache.org>.
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/13677#discussion_r67101246
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
@@ -374,17 +349,35 @@ class DAGScheduler(
}
/**
+ * Create a ResultStage associated with the provided jobId.
+ */
+ private def createResultStage(
+ rdd: RDD[_],
+ func: (TaskContext, Iterator[_]) => _,
+ partitions: Array[Int],
+ jobId: Int,
+ callSite: CallSite): ResultStage = {
+ val id = nextStageId.getAndIncrement()
+ val stage = new ResultStage(
+ id, rdd, func, partitions, getOrCreateParentStages(rdd, jobId), jobId, callSite)
--- End diff --
from a quick check, I think that might solve all the failing tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13677
**[Test build #60714 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60714/consoleFull)** for PR 13677 at commit [`22c6e42`](https://github.com/apache/spark/commit/22c6e4204bf102c001871e3763207f146717f517).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13677
**[Test build #60540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60540/consoleFull)** for PR 13677 at commit [`1b7a338`](https://github.com/apache/spark/commit/1b7a3386fb631f1a41ea73d6bfdc9961ed8e4234).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by kayousterhout <gi...@git.apache.org>.
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/13677
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13677
**[Test build #60540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60540/consoleFull)** for PR 13677 at commit [`1b7a338`](https://github.com/apache/spark/commit/1b7a3386fb631f1a41ea73d6bfdc9961ed8e4234).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13677
**[Test build #60580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60580/consoleFull)** for PR 13677 at commit [`22c6e42`](https://github.com/apache/spark/commit/22c6e4204bf102c001871e3763207f146717f517).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13677: [SPARK 15926] Improve readability of DAGScheduler...
Posted by squito <gi...@git.apache.org>.
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/13677#discussion_r67099857
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
@@ -374,17 +349,35 @@ class DAGScheduler(
}
/**
+ * Create a ResultStage associated with the provided jobId.
+ */
+ private def createResultStage(
+ rdd: RDD[_],
+ func: (TaskContext, Iterator[_]) => _,
+ partitions: Array[Int],
+ jobId: Int,
+ callSite: CallSite): ResultStage = {
+ val id = nextStageId.getAndIncrement()
+ val stage = new ResultStage(
+ id, rdd, func, partitions, getOrCreateParentStages(rdd, jobId), jobId, callSite)
--- End diff --
`getOrCreateParentStages` should be called before getting the id for the result stage, otherwise the result stage will get numbered below the dependent stages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by kayousterhout <gi...@git.apache.org>.
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/13677
Merged into master (FYI @squito, since I'm guessing there may be minor merge conflicts with your blacklisting work)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13677: [SPARK 15926] Improve readability of DAGScheduler stage ...
Posted by kayousterhout <gi...@git.apache.org>.
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/13677
This test failure is the flakey scheduler test -- but I'll hold off on re-running Jenkins since I'm guessing there will be some comments to address on this anyway (so the tests will need to be re-run after that).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org