Re: [PR] SOLR-18062: Support arbitrary Kafka properties via env and sysprops [solr]

["epugh (via GitHub)" <gi...@apache.org>]

epugh commented on PR #4185:
URL: https://github.com/apache/solr/pull/4185#issuecomment-4614047497

   I did a bit of spelunking, and looked at the the text added to the ref guide:  
   
   ```
   Property names from environment variables are normalized by stripping the prefix, converting to lowercase, and replacing `_` with `.`.
   Values from `solr.crossdc.kafka.` system properties override values from `SOLR_CROSSDC_KAFKA_` environment variables when they map to the same Kafka key.
   Already-populated explicit CrossDC settings are preserved and are not overridden by pass-through values.
   Blank values and empty normalized keys are ignored
   ```
   
   So, without some more work, EnvUtils doesn't work as a direct swap....    It doesn't replicate two of our four documented guarantees — it doesn't drop blank values/empty keys, and it has no notion of preserving already-set explicit CrossDC settings — so swapping it in would silently change behavior.
   
   I don't know if I want to tackle makign those changes since I don't know this area very well...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org