You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by TengYao Chi <ki...@gmail.com> on 2024/10/07 02:23:12 UTC
[VOTE] KIP-1092: Extend Consumer#close with an option to leave the group or not
Hi everyone,
Based on our discussion
<https://lists.apache.org/thread/023mo7lk1vfvljjoovwbzwmw9wvf5t6m>
regarding KIP-1092 <https://cwiki.apache.org/confluence/x/JQstEw>, I
believe this KIP is now ready for a vote.
Sincerely,
TengYao
Re: [VOTE] KIP-1092: Extend Consumer#close with an option to leave the group or not
Posted by TengYao Chi <ki...@gmail.com>.
Hello everyone,
The vote is now closed, and the KIP has been accepted with 3 binding +1s
from Chia-Ping, Sophie, Matthias, as well as 3 non-binding +1 from Andrew,
Kirk, Apoorv.
Thank you all for your participation!
Sincerely,
TengYao
Matthias J. Sax <mj...@apache.org> 於 2024年10月19日 週六 上午1:54寫道：
> +1 (binding)
>
>
>
> On 10/11/24 3:15 AM, Apoorv Mittal wrote:
> > Hi TengYao,
> > Thanks for the KIP.
> >
> > +1 (non-binding)
> >
> > Regards,
> > Apoorv Mittal
> >
> >
> > On Fri, Oct 11, 2024 at 12:55 AM Sophie Blee-Goldman <
> sophie@responsive.dev>
> > wrote:
> >
> >> +1 (binding)
> >>
> >> Thanks for this KIP!
> >>
> >> On Mon, Oct 7, 2024 at 9:22 AM Kirk True <ki...@kirktrue.pro> wrote:
> >>
> >>> Hi TengYao,
> >>>
> >>> +1 (non-binding)
> >>>
> >>> Thanks for all the work so far on this.
> >>>
> >>> Kirk
> >>>
> >>> On Mon, Oct 7, 2024, at 4:09 AM, TengYao Chi wrote:
> >>>> Hi Andrew,
> >>>>
> >>>> Thanks for reviewing and participating in the vote.
> >>>> I have corrected the issue as you pointed out.
> >>>>
> >>>> Sincerely,
> >>>> TengYao
> >>>>
> >>>> Andrew Schofield <an...@outlook.com> 於 2024年10月7日 週一
> >>>> 下午6:44寫道：
> >>>>
> >>>>> Thanks for the KIP.
> >>>>>
> >>>>> +1 (non-binding)
> >>>>>
> >>>>> I have one tiny nit that in the text but not the code snippet, you
> >>> mention
> >>>>> methods called
> >>>>> CloseOption.withTimeoutFluent(Duration timeout) and
> >>>>>
> >> CloseOption.withGroupMembershipOperationFluent(GroupMembershipOperation
> >>>>> operation).
> >>>>> I expect you meant to remove "Fluent" in all cases so the text
> >> matches
> >>> the
> >>>>> code snippet.
> >>>>>
> >>>>> Andrew
> >>>>>
> >>>>> ________________________________________
> >>>>> From: TengYao Chi <ki...@gmail.com>
> >>>>> Sent: 07 October 2024 08:44
> >>>>> To: dev@kafka.apache.org <de...@kafka.apache.org>
> >>>>> Subject: Re: [VOTE] KIP-1092: Extend Consumer#close with an option to
> >>>>> leave the group or not
> >>>>>
> >>>>> Hi Chia-Ping,
> >>>>>
> >>>>> Thanks for pointing that out.
> >>>>> I originally wrote the full version to show the equivalent semantic
> >>>>> example, but you're absolutely right—it can be simplified by omitting
> >>>>> `.withGroupMembershipOperation(GroupMembershipOperation.DEFAULT)`
> >> since
> >>>>> it's the default value.
> >>>>>
> >>>>> This actually gave me an idea to include the shorter version for
> >>> clarity in
> >>>>> the explanation.
> >>>>> I will update it accordingly.
> >>>>>
> >>>>> Sincerely,
> >>>>> TengYao
> >>>>>
> >>>>> Chia-Ping Tsai <ch...@gmail.com> 於 2024年10月7日 週一 下午1:13寫道：
> >>>>>
> >>>>>> +1 (binding)
> >>>>>>
> >>>>>> nit: in the "Migration Plan"
> >>>>>>
> >>>>>> ```
> >>>>>> consumer.close(CloseOption.timeout(Duration.ofSeconds(30))
> >>>>>>
> >> .withGroupMembershipOperation(GroupMembershipOperation.DEFAULT));
> >>>>>> ```
> >>>>>>
> >>>>>> The sample above can likely be simplified, right?
> >>>>>>
> >>>>>> ```
> >>>>>> consumer.close(CloseOption.timeout(Duration.ofSeconds(30)));
> >>>>>> ```
> >>>>>>
> >>>>>> Best,
> >>>>>> Chia-Ping
> >>>>>>
> >>>>>> TengYao Chi <ki...@gmail.com> 於 2024年10月7日 週一 上午10:23寫道：
> >>>>>>
> >>>>>>> Hi everyone,
> >>>>>>>
> >>>>>>> Based on our discussion
> >>>>>>> <
> >> https://lists.apache.org/thread/023mo7lk1vfvljjoovwbzwmw9wvf5t6m>
> >>>>>>> regarding KIP-1092 <
> >> https://cwiki.apache.org/confluence/x/JQstEw>,
> >>> I
> >>>>>>> believe this KIP is now ready for a vote.
> >>>>>>>
> >>>>>>> Sincerely,
> >>>>>>> TengYao
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>>
> >>
> >
>
Re: [VOTE] KIP-1092: Extend Consumer#close with an option to leave the group or not
Posted by "Matthias J. Sax" <mj...@apache.org>.
+1 (binding)
On 10/11/24 3:15 AM, Apoorv Mittal wrote:
> Hi TengYao,
> Thanks for the KIP.
>
> +1 (non-binding)
>
> Regards,
> Apoorv Mittal
>
>
> On Fri, Oct 11, 2024 at 12:55 AM Sophie Blee-Goldman <so...@responsive.dev>
> wrote:
>
>> +1 (binding)
>>
>> Thanks for this KIP!
>>
>> On Mon, Oct 7, 2024 at 9:22 AM Kirk True <ki...@kirktrue.pro> wrote:
>>
>>> Hi TengYao,
>>>
>>> +1 (non-binding)
>>>
>>> Thanks for all the work so far on this.
>>>
>>> Kirk
>>>
>>> On Mon, Oct 7, 2024, at 4:09 AM, TengYao Chi wrote:
>>>> Hi Andrew,
>>>>
>>>> Thanks for reviewing and participating in the vote.
>>>> I have corrected the issue as you pointed out.
>>>>
>>>> Sincerely,
>>>> TengYao
>>>>
>>>> Andrew Schofield <an...@outlook.com> 於 2024年10月7日 週一
>>>> 下午6:44寫道：
>>>>
>>>>> Thanks for the KIP.
>>>>>
>>>>> +1 (non-binding)
>>>>>
>>>>> I have one tiny nit that in the text but not the code snippet, you
>>> mention
>>>>> methods called
>>>>> CloseOption.withTimeoutFluent(Duration timeout) and
>>>>>
>> CloseOption.withGroupMembershipOperationFluent(GroupMembershipOperation
>>>>> operation).
>>>>> I expect you meant to remove "Fluent" in all cases so the text
>> matches
>>> the
>>>>> code snippet.
>>>>>
>>>>> Andrew
>>>>>
>>>>> ________________________________________
>>>>> From: TengYao Chi <ki...@gmail.com>
>>>>> Sent: 07 October 2024 08:44
>>>>> To: dev@kafka.apache.org <de...@kafka.apache.org>
>>>>> Subject: Re: [VOTE] KIP-1092: Extend Consumer#close with an option to
>>>>> leave the group or not
>>>>>
>>>>> Hi Chia-Ping,
>>>>>
>>>>> Thanks for pointing that out.
>>>>> I originally wrote the full version to show the equivalent semantic
>>>>> example, but you're absolutely right—it can be simplified by omitting
>>>>> `.withGroupMembershipOperation(GroupMembershipOperation.DEFAULT)`
>> since
>>>>> it's the default value.
>>>>>
>>>>> This actually gave me an idea to include the shorter version for
>>> clarity in
>>>>> the explanation.
>>>>> I will update it accordingly.
>>>>>
>>>>> Sincerely,
>>>>> TengYao
>>>>>
>>>>> Chia-Ping Tsai <ch...@gmail.com> 於 2024年10月7日 週一 下午1:13寫道：
>>>>>
>>>>>> +1 (binding)
>>>>>>
>>>>>> nit: in the "Migration Plan"
>>>>>>
>>>>>> ```
>>>>>> consumer.close(CloseOption.timeout(Duration.ofSeconds(30))
>>>>>>
>> .withGroupMembershipOperation(GroupMembershipOperation.DEFAULT));
>>>>>> ```
>>>>>>
>>>>>> The sample above can likely be simplified, right?
>>>>>>
>>>>>> ```
>>>>>> consumer.close(CloseOption.timeout(Duration.ofSeconds(30)));
>>>>>> ```
>>>>>>
>>>>>> Best,
>>>>>> Chia-Ping
>>>>>>
>>>>>> TengYao Chi <ki...@gmail.com> 於 2024年10月7日 週一 上午10:23寫道：
>>>>>>
>>>>>>> Hi everyone,
>>>>>>>
>>>>>>> Based on our discussion
>>>>>>> <
>> https://lists.apache.org/thread/023mo7lk1vfvljjoovwbzwmw9wvf5t6m>
>>>>>>> regarding KIP-1092 <
>> https://cwiki.apache.org/confluence/x/JQstEw>,
>>> I
>>>>>>> believe this KIP is now ready for a vote.
>>>>>>>
>>>>>>> Sincerely,
>>>>>>> TengYao
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
Re: [VOTE] KIP-1092: Extend Consumer#close with an option to leave the group or not
Posted by Apoorv Mittal <ap...@gmail.com>.
Hi TengYao,
Thanks for the KIP.
+1 (non-binding)
Regards,
Apoorv Mittal
On Fri, Oct 11, 2024 at 12:55 AM Sophie Blee-Goldman <so...@responsive.dev>
wrote:
> +1 (binding)
>
> Thanks for this KIP!
>
> On Mon, Oct 7, 2024 at 9:22 AM Kirk True <ki...@kirktrue.pro> wrote:
>
> > Hi TengYao,
> >
> > +1 (non-binding)
> >
> > Thanks for all the work so far on this.
> >
> > Kirk
> >
> > On Mon, Oct 7, 2024, at 4:09 AM, TengYao Chi wrote:
> > > Hi Andrew,
> > >
> > > Thanks for reviewing and participating in the vote.
> > > I have corrected the issue as you pointed out.
> > >
> > > Sincerely,
> > > TengYao
> > >
> > > Andrew Schofield <an...@outlook.com> 於 2024年10月7日 週一
> > > 下午6:44寫道：
> > >
> > > > Thanks for the KIP.
> > > >
> > > > +1 (non-binding)
> > > >
> > > > I have one tiny nit that in the text but not the code snippet, you
> > mention
> > > > methods called
> > > > CloseOption.withTimeoutFluent(Duration timeout) and
> > > >
> CloseOption.withGroupMembershipOperationFluent(GroupMembershipOperation
> > > > operation).
> > > > I expect you meant to remove "Fluent" in all cases so the text
> matches
> > the
> > > > code snippet.
> > > >
> > > > Andrew
> > > >
> > > > ________________________________________
> > > > From: TengYao Chi <ki...@gmail.com>
> > > > Sent: 07 October 2024 08:44
> > > > To: dev@kafka.apache.org <de...@kafka.apache.org>
> > > > Subject: Re: [VOTE] KIP-1092: Extend Consumer#close with an option to
> > > > leave the group or not
> > > >
> > > > Hi Chia-Ping,
> > > >
> > > > Thanks for pointing that out.
> > > > I originally wrote the full version to show the equivalent semantic
> > > > example, but you're absolutely right—it can be simplified by omitting
> > > > `.withGroupMembershipOperation(GroupMembershipOperation.DEFAULT)`
> since
> > > > it's the default value.
> > > >
> > > > This actually gave me an idea to include the shorter version for
> > clarity in
> > > > the explanation.
> > > > I will update it accordingly.
> > > >
> > > > Sincerely,
> > > > TengYao
> > > >
> > > > Chia-Ping Tsai <ch...@gmail.com> 於 2024年10月7日 週一 下午1:13寫道：
> > > >
> > > > > +1 (binding)
> > > > >
> > > > > nit: in the "Migration Plan"
> > > > >
> > > > > ```
> > > > > consumer.close(CloseOption.timeout(Duration.ofSeconds(30))
> > > > >
> .withGroupMembershipOperation(GroupMembershipOperation.DEFAULT));
> > > > > ```
> > > > >
> > > > > The sample above can likely be simplified, right?
> > > > >
> > > > > ```
> > > > > consumer.close(CloseOption.timeout(Duration.ofSeconds(30)));
> > > > > ```
> > > > >
> > > > > Best,
> > > > > Chia-Ping
> > > > >
> > > > > TengYao Chi <ki...@gmail.com> 於 2024年10月7日 週一 上午10:23寫道：
> > > > >
> > > > > > Hi everyone,
> > > > > >
> > > > > > Based on our discussion
> > > > > > <
> https://lists.apache.org/thread/023mo7lk1vfvljjoovwbzwmw9wvf5t6m>
> > > > > > regarding KIP-1092 <
> https://cwiki.apache.org/confluence/x/JQstEw>,
> > I
> > > > > > believe this KIP is now ready for a vote.
> > > > > >
> > > > > > Sincerely,
> > > > > > TengYao
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] KIP-1092: Extend Consumer#close with an option to leave the group or not
Posted by Sophie Blee-Goldman <so...@responsive.dev>.
+1 (binding)
Thanks for this KIP!
On Mon, Oct 7, 2024 at 9:22 AM Kirk True <ki...@kirktrue.pro> wrote:
> Hi TengYao,
>
> +1 (non-binding)
>
> Thanks for all the work so far on this.
>
> Kirk
>
> On Mon, Oct 7, 2024, at 4:09 AM, TengYao Chi wrote:
> > Hi Andrew,
> >
> > Thanks for reviewing and participating in the vote.
> > I have corrected the issue as you pointed out.
> >
> > Sincerely,
> > TengYao
> >
> > Andrew Schofield <an...@outlook.com> 於 2024年10月7日 週一
> > 下午6:44寫道：
> >
> > > Thanks for the KIP.
> > >
> > > +1 (non-binding)
> > >
> > > I have one tiny nit that in the text but not the code snippet, you
> mention
> > > methods called
> > > CloseOption.withTimeoutFluent(Duration timeout) and
> > > CloseOption.withGroupMembershipOperationFluent(GroupMembershipOperation
> > > operation).
> > > I expect you meant to remove "Fluent" in all cases so the text matches
> the
> > > code snippet.
> > >
> > > Andrew
> > >
> > > ________________________________________
> > > From: TengYao Chi <ki...@gmail.com>
> > > Sent: 07 October 2024 08:44
> > > To: dev@kafka.apache.org <de...@kafka.apache.org>
> > > Subject: Re: [VOTE] KIP-1092: Extend Consumer#close with an option to
> > > leave the group or not
> > >
> > > Hi Chia-Ping,
> > >
> > > Thanks for pointing that out.
> > > I originally wrote the full version to show the equivalent semantic
> > > example, but you're absolutely right—it can be simplified by omitting
> > > `.withGroupMembershipOperation(GroupMembershipOperation.DEFAULT)` since
> > > it's the default value.
> > >
> > > This actually gave me an idea to include the shorter version for
> clarity in
> > > the explanation.
> > > I will update it accordingly.
> > >
> > > Sincerely,
> > > TengYao
> > >
> > > Chia-Ping Tsai <ch...@gmail.com> 於 2024年10月7日 週一 下午1:13寫道：
> > >
> > > > +1 (binding)
> > > >
> > > > nit: in the "Migration Plan"
> > > >
> > > > ```
> > > > consumer.close(CloseOption.timeout(Duration.ofSeconds(30))
> > > > .withGroupMembershipOperation(GroupMembershipOperation.DEFAULT));
> > > > ```
> > > >
> > > > The sample above can likely be simplified, right?
> > > >
> > > > ```
> > > > consumer.close(CloseOption.timeout(Duration.ofSeconds(30)));
> > > > ```
> > > >
> > > > Best,
> > > > Chia-Ping
> > > >
> > > > TengYao Chi <ki...@gmail.com> 於 2024年10月7日 週一 上午10:23寫道：
> > > >
> > > > > Hi everyone,
> > > > >
> > > > > Based on our discussion
> > > > > <https://lists.apache.org/thread/023mo7lk1vfvljjoovwbzwmw9wvf5t6m>
> > > > > regarding KIP-1092 <https://cwiki.apache.org/confluence/x/JQstEw>,
> I
> > > > > believe this KIP is now ready for a vote.
> > > > >
> > > > > Sincerely,
> > > > > TengYao
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] KIP-1092: Extend Consumer#close with an option to leave the group or not
Posted by Kirk True <ki...@kirktrue.pro>.
Hi TengYao,
+1 (non-binding)
Thanks for all the work so far on this.
Kirk
On Mon, Oct 7, 2024, at 4:09 AM, TengYao Chi wrote:
> Hi Andrew,
>
> Thanks for reviewing and participating in the vote.
> I have corrected the issue as you pointed out.
>
> Sincerely,
> TengYao
>
> Andrew Schofield <an...@outlook.com> 於 2024年10月7日 週一
> 下午6:44寫道：
>
> > Thanks for the KIP.
> >
> > +1 (non-binding)
> >
> > I have one tiny nit that in the text but not the code snippet, you mention
> > methods called
> > CloseOption.withTimeoutFluent(Duration timeout) and
> > CloseOption.withGroupMembershipOperationFluent(GroupMembershipOperation
> > operation).
> > I expect you meant to remove "Fluent" in all cases so the text matches the
> > code snippet.
> >
> > Andrew
> >
> > ________________________________________
> > From: TengYao Chi <ki...@gmail.com>
> > Sent: 07 October 2024 08:44
> > To: dev@kafka.apache.org <de...@kafka.apache.org>
> > Subject: Re: [VOTE] KIP-1092: Extend Consumer#close with an option to
> > leave the group or not
> >
> > Hi Chia-Ping,
> >
> > Thanks for pointing that out.
> > I originally wrote the full version to show the equivalent semantic
> > example, but you're absolutely right—it can be simplified by omitting
> > `.withGroupMembershipOperation(GroupMembershipOperation.DEFAULT)` since
> > it's the default value.
> >
> > This actually gave me an idea to include the shorter version for clarity in
> > the explanation.
> > I will update it accordingly.
> >
> > Sincerely,
> > TengYao
> >
> > Chia-Ping Tsai <ch...@gmail.com> 於 2024年10月7日 週一 下午1:13寫道：
> >
> > > +1 (binding)
> > >
> > > nit: in the "Migration Plan"
> > >
> > > ```
> > > consumer.close(CloseOption.timeout(Duration.ofSeconds(30))
> > > .withGroupMembershipOperation(GroupMembershipOperation.DEFAULT));
> > > ```
> > >
> > > The sample above can likely be simplified, right?
> > >
> > > ```
> > > consumer.close(CloseOption.timeout(Duration.ofSeconds(30)));
> > > ```
> > >
> > > Best,
> > > Chia-Ping
> > >
> > > TengYao Chi <ki...@gmail.com> 於 2024年10月7日 週一 上午10:23寫道：
> > >
> > > > Hi everyone,
> > > >
> > > > Based on our discussion
> > > > <https://lists.apache.org/thread/023mo7lk1vfvljjoovwbzwmw9wvf5t6m>
> > > > regarding KIP-1092 <https://cwiki.apache.org/confluence/x/JQstEw>, I
> > > > believe this KIP is now ready for a vote.
> > > >
> > > > Sincerely,
> > > > TengYao
> > > >
> > >
> >
>
Re: [VOTE] KIP-1092: Extend Consumer#close with an option to leave the group or not
Posted by TengYao Chi <ki...@gmail.com>.
Hi Andrew,
Thanks for reviewing and participating in the vote.
I have corrected the issue as you pointed out.
Sincerely,
TengYao
Andrew Schofield <an...@outlook.com> 於 2024年10月7日 週一
下午6:44寫道：
> Thanks for the KIP.
>
> +1 (non-binding)
>
> I have one tiny nit that in the text but not the code snippet, you mention
> methods called
> CloseOption.withTimeoutFluent(Duration timeout) and
> CloseOption.withGroupMembershipOperationFluent(GroupMembershipOperation
> operation).
> I expect you meant to remove "Fluent" in all cases so the text matches the
> code snippet.
>
> Andrew
>
> ________________________________________
> From: TengYao Chi <ki...@gmail.com>
> Sent: 07 October 2024 08:44
> To: dev@kafka.apache.org <de...@kafka.apache.org>
> Subject: Re: [VOTE] KIP-1092: Extend Consumer#close with an option to
> leave the group or not
>
> Hi Chia-Ping,
>
> Thanks for pointing that out.
> I originally wrote the full version to show the equivalent semantic
> example, but you're absolutely right—it can be simplified by omitting
> `.withGroupMembershipOperation(GroupMembershipOperation.DEFAULT)` since
> it's the default value.
>
> This actually gave me an idea to include the shorter version for clarity in
> the explanation.
> I will update it accordingly.
>
> Sincerely,
> TengYao
>
> Chia-Ping Tsai <ch...@gmail.com> 於 2024年10月7日 週一 下午1:13寫道：
>
> > +1 (binding)
> >
> > nit: in the "Migration Plan"
> >
> > ```
> > consumer.close(CloseOption.timeout(Duration.ofSeconds(30))
> > .withGroupMembershipOperation(GroupMembershipOperation.DEFAULT));
> > ```
> >
> > The sample above can likely be simplified, right?
> >
> > ```
> > consumer.close(CloseOption.timeout(Duration.ofSeconds(30)));
> > ```
> >
> > Best,
> > Chia-Ping
> >
> > TengYao Chi <ki...@gmail.com> 於 2024年10月7日 週一 上午10:23寫道：
> >
> > > Hi everyone,
> > >
> > > Based on our discussion
> > > <https://lists.apache.org/thread/023mo7lk1vfvljjoovwbzwmw9wvf5t6m>
> > > regarding KIP-1092 <https://cwiki.apache.org/confluence/x/JQstEw>, I
> > > believe this KIP is now ready for a vote.
> > >
> > > Sincerely,
> > > TengYao
> > >
> >
>
Re: [VOTE] KIP-1092: Extend Consumer#close with an option to leave the group or not
Posted by Andrew Schofield <an...@outlook.com>.
Thanks for the KIP.
+1 (non-binding)
I have one tiny nit that in the text but not the code snippet, you mention methods called
CloseOption.withTimeoutFluent(Duration timeout) and
CloseOption.withGroupMembershipOperationFluent(GroupMembershipOperation operation).
I expect you meant to remove "Fluent" in all cases so the text matches the code snippet.
Andrew
________________________________________
From: TengYao Chi <ki...@gmail.com>
Sent: 07 October 2024 08:44
To: dev@kafka.apache.org <de...@kafka.apache.org>
Subject: Re: [VOTE] KIP-1092: Extend Consumer#close with an option to leave the group or not
Hi Chia-Ping,
Thanks for pointing that out.
I originally wrote the full version to show the equivalent semantic
example, but you're absolutely right—it can be simplified by omitting
`.withGroupMembershipOperation(GroupMembershipOperation.DEFAULT)` since
it's the default value.
This actually gave me an idea to include the shorter version for clarity in
the explanation.
I will update it accordingly.
Sincerely,
TengYao
Chia-Ping Tsai <ch...@gmail.com> 於 2024年10月7日 週一 下午1:13寫道：
> +1 (binding)
>
> nit: in the "Migration Plan"
>
> ```
> consumer.close(CloseOption.timeout(Duration.ofSeconds(30))
> .withGroupMembershipOperation(GroupMembershipOperation.DEFAULT));
> ```
>
> The sample above can likely be simplified, right?
>
> ```
> consumer.close(CloseOption.timeout(Duration.ofSeconds(30)));
> ```
>
> Best,
> Chia-Ping
>
> TengYao Chi <ki...@gmail.com> 於 2024年10月7日 週一 上午10:23寫道：
>
> > Hi everyone,
> >
> > Based on our discussion
> > <https://lists.apache.org/thread/023mo7lk1vfvljjoovwbzwmw9wvf5t6m>
> > regarding KIP-1092 <https://cwiki.apache.org/confluence/x/JQstEw>, I
> > believe this KIP is now ready for a vote.
> >
> > Sincerely,
> > TengYao
> >
>
Re: [VOTE] KIP-1092: Extend Consumer#close with an option to leave the group or not
Posted by TengYao Chi <ki...@gmail.com>.
Hi Chia-Ping,
Thanks for pointing that out.
I originally wrote the full version to show the equivalent semantic
example, but you're absolutely right—it can be simplified by omitting
`.withGroupMembershipOperation(GroupMembershipOperation.DEFAULT)` since
it's the default value.
This actually gave me an idea to include the shorter version for clarity in
the explanation.
I will update it accordingly.
Sincerely,
TengYao
Chia-Ping Tsai <ch...@gmail.com> 於 2024年10月7日 週一 下午1:13寫道：
> +1 (binding)
>
> nit: in the "Migration Plan"
>
> ```
> consumer.close(CloseOption.timeout(Duration.ofSeconds(30))
> .withGroupMembershipOperation(GroupMembershipOperation.DEFAULT));
> ```
>
> The sample above can likely be simplified, right?
>
> ```
> consumer.close(CloseOption.timeout(Duration.ofSeconds(30)));
> ```
>
> Best,
> Chia-Ping
>
> TengYao Chi <ki...@gmail.com> 於 2024年10月7日 週一 上午10:23寫道：
>
> > Hi everyone,
> >
> > Based on our discussion
> > <https://lists.apache.org/thread/023mo7lk1vfvljjoovwbzwmw9wvf5t6m>
> > regarding KIP-1092 <https://cwiki.apache.org/confluence/x/JQstEw>, I
> > believe this KIP is now ready for a vote.
> >
> > Sincerely,
> > TengYao
> >
>
Re: [VOTE] KIP-1092: Extend Consumer#close with an option to leave the group or not
Posted by Chia-Ping Tsai <ch...@gmail.com>.
+1 (binding)
nit: in the "Migration Plan"
```
consumer.close(CloseOption.timeout(Duration.ofSeconds(30))
.withGroupMembershipOperation(GroupMembershipOperation.DEFAULT));
```
The sample above can likely be simplified, right?
```
consumer.close(CloseOption.timeout(Duration.ofSeconds(30)));
```
Best,
Chia-Ping
TengYao Chi <ki...@gmail.com> 於 2024年10月7日 週一 上午10:23寫道：
> Hi everyone,
>
> Based on our discussion
> <https://lists.apache.org/thread/023mo7lk1vfvljjoovwbzwmw9wvf5t6m>
> regarding KIP-1092 <https://cwiki.apache.org/confluence/x/JQstEw>, I
> believe this KIP is now ready for a vote.
>
> Sincerely,
> TengYao
>