You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Curricane (via GitHub)" <gi...@apache.org> on 2025/01/15 09:51:21 UTC
[PR] bugfix: create view with multi union may get wrong schema [datafusion]
Curricane opened a new pull request, #14133:
URL: https://github.com/apache/datafusion/pull/14133
## Which issue does this PR close?
https://github.com/apache/datafusion/issues/14132
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
yes
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
No
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bugfix: create view with multi union may get wrong schema [datafusion]
Posted by "Curricane (via GitHub)" <gi...@apache.org>.
Curricane commented on PR #14133:
URL: https://github.com/apache/datafusion/pull/14133#issuecomment-2594286581
> Hi @Curricane -- thank you for the fix 🙏
>
> Can you please add some tests, ideally in sqllogicteset format to ensure this behavior is not broken in the future.
>
> Here are the instructions: https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest
>
> Ideally you should be able to extend one of the existing test files in https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest/test_files
>
> Perhaps https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/ddl.slt
Sure, but could we merge this PR first? I can create another PR to handle this task because I'm not very familiar with writing this kind of test and will need some time to work on it. I hope to use the version of DataFusion that fixes this issue as soon as possible since it's critical for my project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bugfix: create view with multi union may get wrong schema [datafusion]
Posted by "jonahgao (via GitHub)" <gi...@apache.org>.
jonahgao merged PR #14133:
URL: https://github.com/apache/datafusion/pull/14133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bugfix: create view with multi union may get wrong schema [datafusion]
Posted by "jonahgao (via GitHub)" <gi...@apache.org>.
jonahgao commented on PR #14133:
URL: https://github.com/apache/datafusion/pull/14133#issuecomment-2594345585
@Curricane Filed a todo issue #14140 for adding tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org