You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Sean Owen (JIRA)" <ji...@apache.org> on 2014/10/13 17:26:33 UTC

[jira] [Resolved] (SPARK-3895) Scala style: Indentation of method

     [ https://issues.apache.org/jira/browse/SPARK-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Owen resolved SPARK-3895.
------------------------------
    Resolution: Won't Fix

Given recent discussion, and consensus to not make sweeping style changes, I think this is WontFix.

> Scala style: Indentation of method
> ----------------------------------
>
>                 Key: SPARK-3895
>                 URL: https://issues.apache.org/jira/browse/SPARK-3895
>             Project: Spark
>          Issue Type: Sub-task
>          Components: Project Infra
>            Reporter: sjk
>
> such as https://github.com/apache/spark/pull/2734
> {code:title=core/src/main/scala/org/apache/spark/Aggregator.scala|borderStyle=solid}
> // for example
>   def combineCombinersByKey(iter: Iterator[_ <: Product2[K, C]], context: TaskContext)
>       : Iterator[(K, C)] =
>   {
> ...
>   def combineValuesByKey(iter: Iterator[_ <: Product2[K, V]],
>                          context: TaskContext): Iterator[(K, C)] = {
> {code}
> there are not conform to the rule.https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
> there are so much code like this



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org