You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Luke Cwik (JIRA)" <ji...@apache.org> on 2017/10/03 20:05:00 UTC

[jira] [Commented] (BEAM-3003) In WithKeys, get coder for key more safely.

    [ https://issues.apache.org/jira/browse/BEAM-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190251#comment-16190251 ] 

Luke Cwik commented on BEAM-3003:
---------------------------------

There is also the problem that we aren't serializing the provided key with the coder and instead rely on Java serialization.

> In WithKeys, get coder for key more safely.
> -------------------------------------------
>
>                 Key: BEAM-3003
>                 URL: https://issues.apache.org/jira/browse/BEAM-3003
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Daniel Oliveira
>            Priority: Minor
>              Labels: starter
>
> In WithKeys.java currently the coder for the key type is chosen when the transform is expanded. This means that there's no way to directly get the type of the input elements, instead the type is inferred from the function or from a java Class<> object. This means there can be mismatches between the actual type of the input and the coder used.
> WithKeys should be refactored to retrieve the coder in a safer way and avoid the possibility of mismatches. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)