You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/21 01:14:38 UTC
[GitHub] [incubator-superset] ktmud opened a new pull request #11771: test: add React Testing Library
ktmud opened a new pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771
### SUMMARY
Implement [[SIP-56] Adopt React Testing Library for testing React components](https://github.com/apache/incubator-superset/issues/11688).
- Add React Testing Library
- Updated the setup files
- Convert a couple of existing components with the new library
Note that in order to use `waitFor`, one must explicitly add a `jest-environment: jsdom` docblock to the test file, because the default jest environment `jest-enzyme` is not compatible with this functionality.
```ts
/**
* @jest-environment jsdom
*/
```
Another lesson learned in writing tests for RTL: if your test uses `useEffect` to updated the DOM, make sure to use [waitFor](https://testing-library.com/docs/dom-testing-library/api-async/) API to wait for the DOM change, otherwise you may encounter `an update inside a test was not wrapped in act(...)` errors.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TEST PLAN
CI
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (4f7c131) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `2.62%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 63.47% -2.63%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17406 -11492
+ Misses 14701 10014 -4687
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.47% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../src/explore/components/MetricDefinitionOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uT3B0aW9uLmpzeA==) | | |
| [...erset-frontend/src/messageToasts/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvcmVkdWNlcnMvaW5kZXguanM=) | | |
| [...d/src/dashboard/util/updateComponentParentsList.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3VwZGF0ZUNvbXBvbmVudFBhcmVudHNMaXN0Lmpz) | | |
| [superset-frontend/src/setup/setupClient.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ2xpZW50Lmpz) | | |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | | |
| [...ntend/src/dashboard/util/activeDashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2FjdGl2ZURhc2hib2FyZEZpbHRlcnMuanM=) | | |
| [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | | |
| [...et-frontend/src/components/Label/Label.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvTGFiZWwuc3Rvcmllcy50c3g=) | | |
| [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | | |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | | |
| ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...4f7c131](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (3a292a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `3.56%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 62.53% -3.57%
==========================================
Files 903 446 -457
Lines 43719 27409 -16310
Branches 4199 0 -4199
==========================================
- Hits 28898 17139 -11759
+ Misses 14701 10270 -4431
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `62.53% <ø> (-0.95%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-11.88%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.93% <0.00%> (-5.47%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [472 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...3a292a4](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (362417d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `3.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 62.87% -3.23%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17241 -11657
+ Misses 14701 10179 -4522
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `62.87% <ø> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-11.88%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.09% <0.00%> (-0.14%)` | :arrow_down: |
| [...src/dashboard/components/FiltersBadge/selectors.ts](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9zZWxlY3RvcnMudHM=) | | |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | | |
| ... and [453 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...362417d](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (362417d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `2.84%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 63.24% -2.85%
==========================================
Files 903 903
Lines 43719 43711 -8
Branches 4199 4199
==========================================
- Hits 28898 27647 -1251
- Misses 14701 15884 +1183
- Partials 120 180 +60
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.86% <100.00%> (+0.01%)` | :arrow_up: |
| python | `63.47% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Timer.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIudHN4) | `91.66% <100.00%> (-4.17%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [138 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...362417d](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (362417d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `3.56%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 62.53% -3.57%
==========================================
Files 903 446 -457
Lines 43719 27409 -16310
Branches 4199 0 -4199
==========================================
- Hits 28898 17139 -11759
+ Misses 14701 10270 -4431
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `62.53% <ø> (-0.95%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-11.88%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.93% <0.00%> (-5.47%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [472 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...362417d](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (3a292a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `2.60%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 63.49% -2.61%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17409 -11489
+ Misses 14701 10011 -4690
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.49% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/middleware/loggerMiddleware.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvbG9nZ2VyTWlkZGxld2FyZS5qcw==) | | |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | | |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | | |
| [superset-frontend/src/logger/LogUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2xvZ2dlci9Mb2dVdGlscy5qcw==) | | |
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | | |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | | |
| [...et-frontend/src/explore/controlPanels/sections.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9zZWN0aW9ucy5qc3g=) | | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | | |
| [...d/src/dashboard/util/updateComponentParentsList.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3VwZGF0ZUNvbXBvbmVudFBhcmVudHNMaXN0Lmpz) | | |
| [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | | |
| ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...3a292a4](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (362417d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **increase** coverage by `1.16%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
+ Coverage 66.09% 67.26% +1.16%
==========================================
Files 903 903
Lines 43719 43719
Branches 4199 4199
==========================================
+ Hits 28898 29407 +509
+ Misses 14701 14208 -493
+ Partials 120 104 -16
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.37% <100.00%> (+6.61%)` | :arrow_up: |
| javascript | `62.86% <100.00%> (+0.01%)` | :arrow_up: |
| python | `63.49% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Timer.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIudHN4) | `95.83% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.28% <0.00%> (+0.64%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `78.94% <0.00%> (+1.05%)` | :arrow_up: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `89.65% <0.00%> (+1.14%)` | :arrow_up: |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `37.50% <0.00%> (+1.56%)` | :arrow_up: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
| [superset-frontend/src/utils/common.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvbW1vbi5qcw==) | `74.19% <0.00%> (+1.61%)` | :arrow_up: |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | `98.03% <0.00%> (+1.96%)` | :arrow_up: |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `88.88% <0.00%> (+2.77%)` | :arrow_up: |
| ... and [52 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...362417d](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (4f7c131) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `2.62%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 63.47% -2.63%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17406 -11492
+ Misses 14701 10014 -4687
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.47% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...hboard/components/gridComponents/new/NewColumn.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdDb2x1bW4uanN4) | | |
| [...rontend/src/visualizations/TimeTable/TimeTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9UaW1lVGFibGUuanN4) | | |
| [superset-frontend/src/profile/components/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9BcHAudHN4) | | |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | | |
| [superset-frontend/src/components/AnchorLink.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay5qc3g=) | | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | | |
| [...tend/src/SqlLab/components/ScheduleQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24uanN4) | | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | | |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | | |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | | |
| ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...4f7c131](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (4f7c131) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `2.62%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 63.47% -2.63%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17406 -11492
+ Misses 14701 10014 -4687
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.47% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../src/explore/components/MetricDefinitionOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uT3B0aW9uLmpzeA==) | | |
| [...erset-frontend/src/messageToasts/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvcmVkdWNlcnMvaW5kZXguanM=) | | |
| [...d/src/dashboard/util/updateComponentParentsList.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3VwZGF0ZUNvbXBvbmVudFBhcmVudHNMaXN0Lmpz) | | |
| [superset-frontend/src/setup/setupClient.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ2xpZW50Lmpz) | | |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | | |
| [...ntend/src/dashboard/util/activeDashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2FjdGl2ZURhc2hib2FyZEZpbHRlcnMuanM=) | | |
| [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | | |
| [...et-frontend/src/components/Label/Label.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvTGFiZWwuc3Rvcmllcy50c3g=) | | |
| [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | | |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | | |
| ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...4f7c131](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (362417d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **increase** coverage by `0.98%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
+ Coverage 66.09% 67.08% +0.98%
==========================================
Files 903 903
Lines 43719 43719
Branches 4199 4199
==========================================
+ Hits 28898 29329 +431
+ Misses 14701 14282 -419
+ Partials 120 108 -12
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.52% <100.00%> (+5.76%)` | :arrow_up: |
| javascript | `62.86% <100.00%> (+0.01%)` | :arrow_up: |
| python | `63.49% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Timer.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIudHN4) | `95.83% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.12% <0.00%> (-5.17%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (-4.28%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `45.83% <0.00%> (-4.17%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.60% <0.00%> (-3.31%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `59.49% <0.00%> (-1.27%)` | :arrow_down: |
| ... and [61 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...362417d](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (3a292a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `2.77%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 63.32% -2.78%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17363 -11535
+ Misses 14701 10057 -4644
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.32% <ø> (-0.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.00%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.09% <0.00%> (-0.14%)` | :arrow_down: |
| [superset-frontend/src/components/CheckboxIcons.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3hJY29ucy50c3g=) | | |
| [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | | |
| [.../src/dashboard/components/menu/WithPopoverMenu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvV2l0aFBvcG92ZXJNZW51LmpzeA==) | | |
| [...set-frontend/src/common/components/InfoTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwLnRzeA==) | | |
| [...t-frontend/src/dashboard/reducers/sliceEntities.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9zbGljZUVudGl0aWVzLmpz) | | |
| ... and [450 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...3a292a4](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (54e905c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/872a54d304f637e695e677233d7267aa56605d75?el=desc) (872a54d) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
=======================================
Coverage 67.29% 67.29%
=======================================
Files 905 905
Lines 43862 43862
Branches 4201 4201
=======================================
Hits 29519 29519
Misses 14239 14239
Partials 104 104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.12% <100.00%> (ø)` | |
| javascript | `62.86% <100.00%> (+0.01%)` | :arrow_up: |
| python | `63.64% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Timer.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIudHN4) | `95.83% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [872a54d...ae3f033](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (3a292a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `2.60%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 63.49% -2.61%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17409 -11489
+ Misses 14701 10011 -4690
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.49% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | | |
| [...shboard/components/filterscope/FilterScopeTree.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlVHJlZS5qc3g=) | | |
| [...explore/components/controls/ColorSchemeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclNjaGVtZUNvbnRyb2wuanN4) | | |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | | |
| [...hboard/util/getChartAndLabelComponentIdFromPath.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENoYXJ0QW5kTGFiZWxDb21wb25lbnRJZEZyb21QYXRoLmpz) | | |
| [...end/src/components/Select/SupersetStyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1N1cGVyc2V0U3R5bGVkU2VsZWN0LnRzeA==) | | |
| [superset-frontend/src/showSavedQuery/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Nob3dTYXZlZFF1ZXJ5L2luZGV4LmpzeA==) | | |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | | |
| [...end/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9EcmFnRHJvcHBhYmxlLmpzeA==) | | |
| [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkVHJlZS5qc3g=) | | |
| ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...3a292a4](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (362417d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **increase** coverage by `1.11%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
+ Coverage 66.09% 67.21% +1.11%
==========================================
Files 903 903
Lines 43719 43719
Branches 4199 4199
==========================================
+ Hits 28898 29385 +487
+ Misses 14701 14230 -471
+ Partials 120 104 -16
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.12% <100.00%> (+6.36%)` | :arrow_up: |
| javascript | `62.86% <100.00%> (+0.01%)` | :arrow_up: |
| python | `63.49% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Timer.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIudHN4) | `95.83% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.28% <0.00%> (+0.64%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `78.94% <0.00%> (+1.05%)` | :arrow_up: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `89.65% <0.00%> (+1.14%)` | :arrow_up: |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `37.50% <0.00%> (+1.56%)` | :arrow_up: |
| [superset-frontend/src/utils/common.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvbW1vbi5qcw==) | `74.19% <0.00%> (+1.61%)` | :arrow_up: |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | `98.03% <0.00%> (+1.96%)` | :arrow_up: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `82.79% <0.00%> (+2.15%)` | :arrow_up: |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `88.88% <0.00%> (+2.77%)` | :arrow_up: |
| ... and [51 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...362417d](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (3a292a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `2.60%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 63.49% -2.61%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17409 -11489
+ Misses 14701 10011 -4690
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.49% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/dashboard/util/resizableConfig.ts](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Jlc2l6YWJsZUNvbmZpZy50cw==) | | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | | |
| [superset-frontend/src/CRUD/Fieldset.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGRzZXQuanN4) | | |
| [...end/src/components/Select/SupersetStyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1N1cGVyc2V0U3R5bGVkU2VsZWN0LnRzeA==) | | |
| [...t-frontend/src/SqlLab/components/TabStatusIcon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYlN0YXR1c0ljb24uanN4) | | |
| [...t-frontend/src/views/CRUD/data/query/QueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeUxpc3QudHN4) | | |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | | |
| [.../dashboard/util/logging/findNonTabChildChartIds.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZmluZE5vblRhYkNoaWxkQ2hhcnRJZHMuanM=) | | |
| [...ntend/src/dashboard/util/activeDashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2FjdGl2ZURhc2hib2FyZEZpbHRlcnMuanM=) | | |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | | |
| ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...3a292a4](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (3a292a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `3.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 62.87% -3.23%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17241 -11657
+ Misses 14701 10179 -4522
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `62.87% <ø> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-11.88%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.09% <0.00%> (-0.14%)` | :arrow_down: |
| [...rontend/src/explore/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwudHN4) | | |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | | |
| ... and [453 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...3a292a4](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (3a292a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `3.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 62.87% -3.23%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17241 -11657
+ Misses 14701 10179 -4522
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `62.87% <ø> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-11.88%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.09% <0.00%> (-0.14%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | | |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | | |
| ... and [453 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...3a292a4](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (3a292a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `2.60%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 63.49% -2.61%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17409 -11489
+ Misses 14701 10011 -4690
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.49% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...shboard/util/charts/getFormDataWithExtraFilters.ts](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRGb3JtRGF0YVdpdGhFeHRyYUZpbHRlcnMudHM=) | | |
| [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | | |
| [...frontend/src/dashboard/util/newEntitiesFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0VudGl0aWVzRnJvbURyb3AuanM=) | | |
| [...et-frontend/src/components/ListView/ActionsBar.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQWN0aW9uc0Jhci50c3g=) | | |
| [...end/src/components/Select/SupersetStyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1N1cGVyc2V0U3R5bGVkU2VsZWN0LnRzeA==) | | |
| [...e/controlPanels/timeGrainSqlaAnimationOverrides.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy90aW1lR3JhaW5TcWxhQW5pbWF0aW9uT3ZlcnJpZGVzLmpz) | | |
| [...rontend/src/dashboard/util/componentIsResizable.ts](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudElzUmVzaXphYmxlLnRz) | | |
| [...ashboard/components/gridComponents/new/NewTabs.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdUYWJzLmpzeA==) | | |
| [...uperset-frontend/src/common/components/Tooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAudHN4) | | |
| [...end/src/visualizations/FilterBox/transformProps.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC90cmFuc2Zvcm1Qcm9wcy5qcw==) | | |
| ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...3a292a4](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (362417d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `2.84%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 63.25% -2.85%
==========================================
Files 903 903
Lines 43719 43711 -8
Branches 4199 4199
==========================================
- Hits 28898 27650 -1248
- Misses 14701 15881 +1180
- Partials 120 180 +60
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.86% <100.00%> (+0.01%)` | :arrow_up: |
| python | `63.49% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Timer.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIudHN4) | `91.66% <100.00%> (-4.17%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [139 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...362417d](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud merged pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (4f7c131) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `2.62%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 63.47% -2.63%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17406 -11492
+ Misses 14701 10014 -4687
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.47% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/components/ListView/ActionsBar.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQWN0aW9uc0Jhci50c3g=) | | |
| [...ntend/src/components/FacePile/FacePile.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmFjZVBpbGUvRmFjZVBpbGUuc3Rvcmllcy50c3g=) | | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | | |
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | | |
| [...frontend/src/dashboard/util/dropOverflowsParent.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2Ryb3BPdmVyZmxvd3NQYXJlbnQuanM=) | | |
| [...frontend/src/dashboard/components/MissingChart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL01pc3NpbmdDaGFydC5qc3g=) | | |
| [...et-frontend/src/explore/controlPanels/Separator.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TZXBhcmF0b3IuanM=) | | |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | | |
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | | |
| [...rontend/src/dashboard/util/shouldWrapChildInRow.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Nob3VsZFdyYXBDaGlsZEluUm93Lmpz) | | |
| ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...4f7c131](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (3a292a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `2.60%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 63.49% -2.61%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17409 -11489
+ Misses 14701 10011 -4690
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.49% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | | |
| [...rontend/src/dashboard/util/shouldWrapChildInRow.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Nob3VsZFdyYXBDaGlsZEluUm93Lmpz) | | |
| [...rontend/src/components/ListView/CardSortSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZFNvcnRTZWxlY3QudHN4) | | |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | | |
| [...ntend/src/dashboard/util/getRevertedFilterScope.ts](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldFJldmVydGVkRmlsdGVyU2NvcGUudHM=) | | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | | |
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | | |
| [.../src/dashboard/components/BuilderComponentPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLmpzeA==) | | |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | | |
| [superset-frontend/src/dashboard/util/constants.ts](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbnN0YW50cy50cw==) | | |
| ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...3a292a4](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (362417d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `3.22%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 62.87% -3.23%
==========================================
Files 903 903
Lines 43719 43711 -8
Branches 4199 4199
==========================================
- Hits 28898 27482 -1416
- Misses 14701 16049 +1348
- Partials 120 180 +60
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.86% <100.00%> (+0.01%)` | :arrow_up: |
| python | `62.87% <ø> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Timer.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIudHN4) | `91.66% <100.00%> (-4.17%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [146 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...362417d](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (4f7c131) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `2.62%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 63.47% -2.63%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17406 -11492
+ Misses 14701 10014 -4687
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.47% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../src/explore/components/MetricDefinitionOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uT3B0aW9uLmpzeA==) | | |
| [...erset-frontend/src/messageToasts/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvcmVkdWNlcnMvaW5kZXguanM=) | | |
| [...d/src/dashboard/util/updateComponentParentsList.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3VwZGF0ZUNvbXBvbmVudFBhcmVudHNMaXN0Lmpz) | | |
| [superset-frontend/src/setup/setupClient.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ2xpZW50Lmpz) | | |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | | |
| [...ntend/src/dashboard/util/activeDashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2FjdGl2ZURhc2hib2FyZEZpbHRlcnMuanM=) | | |
| [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | | |
| [...et-frontend/src/components/Label/Label.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvTGFiZWwuc3Rvcmllcy50c3g=) | | |
| [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | | |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | | |
| ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...4f7c131](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (3a292a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `2.60%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 63.49% -2.61%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17409 -11489
+ Misses 14701 10011 -4690
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.49% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/components/ListView/ActionsBar.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQWN0aW9uc0Jhci50c3g=) | | |
| [...ntend/src/components/FacePile/FacePile.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmFjZVBpbGUvRmFjZVBpbGUuc3Rvcmllcy50c3g=) | | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | | |
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | | |
| [...frontend/src/dashboard/util/dropOverflowsParent.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2Ryb3BPdmVyZmxvd3NQYXJlbnQuanM=) | | |
| [...frontend/src/dashboard/components/MissingChart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL01pc3NpbmdDaGFydC5qc3g=) | | |
| [...et-frontend/src/explore/controlPanels/Separator.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TZXBhcmF0b3IuanM=) | | |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | | |
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | | |
| [...rontend/src/dashboard/util/shouldWrapChildInRow.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Nob3VsZFdyYXBDaGlsZEluUm93Lmpz) | | |
| ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...3a292a4](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (4f7c131) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `2.62%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 63.47% -2.63%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17406 -11492
+ Misses 14701 10014 -4687
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.47% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/components/FacePile/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmFjZVBpbGUvdXRpbHMudHN4) | | |
| [.../src/dashboard/util/serializeActiveFilterValues.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUFjdGl2ZUZpbHRlclZhbHVlcy5qcw==) | | |
| [superset-frontend/src/CRUD/CollectionTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvQ29sbGVjdGlvblRhYmxlLnRzeA==) | | |
| [...t-frontend/src/dashboard/components/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlQWRkZXIuanN4) | | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | | |
| [...et-frontend/src/explore/controlPanels/Separator.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TZXBhcmF0b3IuanM=) | | |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | | |
| [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | | |
| ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...4f7c131](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (3a292a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `3.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 62.87% -3.23%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17241 -11657
+ Misses 14701 10179 -4522
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `62.87% <ø> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-11.88%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.09% <0.00%> (-0.14%)` | :arrow_down: |
| [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | | |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | | |
| ... and [453 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...3a292a4](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (3a292a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `2.77%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 63.32% -2.78%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17363 -11535
+ Misses 14701 10057 -4644
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.32% <ø> (-0.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.00%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.09% <0.00%> (-0.14%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | | |
| [...d/src/dashboard/components/FiltersBadge/Styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9TdHlsZXMudHN4) | | |
| [...c/components/ErrorMessage/DatabaseErrorMessage.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0RhdGFiYXNlRXJyb3JNZXNzYWdlLnRzeA==) | | |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | | |
| ... and [450 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...3a292a4](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (362417d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `3.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 62.88% -3.22%
==========================================
Files 903 446 -457
Lines 43719 27409 -16310
Branches 4199 0 -4199
==========================================
- Hits 28898 17236 -11662
+ Misses 14701 10173 -4528
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `62.88% <ø> (-0.60%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-11.88%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.61% <0.00%> (-0.48%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.08% <0.00%> (-0.15%)` | :arrow_down: |
| ... and [459 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...362417d](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=h1) Report
> Merging [#11771](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=desc) (3a292a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fbe4a6622e0affd6568ba0d5c429dc6bec18f626?el=desc) (fbe4a66) will **decrease** coverage by `3.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.09% 62.81% -3.29%
==========================================
Files 903 446 -457
Lines 43719 27420 -16299
Branches 4199 0 -4199
==========================================
- Hits 28898 17225 -11673
+ Misses 14701 10195 -4506
+ Partials 120 0 -120
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `62.81% <ø> (-0.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-11.88%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.72% <0.00%> (-0.48%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.95% <0.00%> (-0.27%)` | :arrow_down: |
| ... and [455 more](https://codecov.io/gh/apache/incubator-superset/pull/11771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=footer). Last update [fbe4a66...3a292a4](https://codecov.io/gh/apache/incubator-superset/pull/11771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11771: test: add React Testing Library
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11771:
URL: https://github.com/apache/incubator-superset/pull/11771#issuecomment-731482337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org