[GitHub] [incubator-pinot] icefury71 commented on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance

[GitBox <gi...@apache.org>]

icefury71 commented on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance
URL: https://github.com/apache/incubator-pinot/pull/4952#issuecomment-571335765
 
 
   > Helix provides commands to add/remove/list tags, so the only value added in making this a part of pinot is to make sure that the tags correspond to the conventions used/allowed in pinot. Even this is not completely predictable, because we can use pretty much any tag name in [tagOverrideConfig](https://github.com/apache/incubator-pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/config/TagOverrideConfig.java). I suggest that we refer the admins to the helix commands to do this operation instead of adding code in pinot. We can add documentation on specific helix commands in pinot docs.
   
   Thanks for your comments @mcvsubbu . I believe this API is still useful for the following reasons:
   1) Adding a "tenant" as a tag is a very Pinot specific operation. We may not be able to do pre-requisite checks if we do this through helix (eg: retagging from one tenant to another).
   2) Having one admin API endpoint is very convenient and allows for the caller (eg: automated cluster/setup tenant, node replacement etc).
   
   Lemme know if you have any more questions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org