You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/03 20:12:21 UTC

[GitHub] [incubator-nuttx] acassis opened a new pull request #2971: esp32: Add board config to support MCP2515

acassis opened a new pull request #2971:
URL: https://github.com/apache/incubator-nuttx/pull/2971


   ## Summary
   Add board config to support MCP2515
   ## Impact
   Only ESP32-Devkit
   ## Testing
   ESP32-Devkit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 merged pull request #2971: esp32: Add board config to support MCP2515

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #2971:
URL: https://github.com/apache/incubator-nuttx/pull/2971


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2971: esp32: Add board config to support MCP2515

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #2971:
URL: https://github.com/apache/incubator-nuttx/pull/2971#discussion_r586766988



##########
File path: boards/xtensa/esp32/esp32-devkitc/src/esp32_mcp2515.c
##########
@@ -0,0 +1,250 @@
+/****************************************************************************
+ * boards/xtensa/esp32/esp32devkitc/src/esp32_mcp2515.c

Review comment:
       Why is this not part of the common board logic?
   I checked stm32 and it also there only stm32f3-minimum and not in the common folder.  Is there any particularities?  I can't see any from my side.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #2971: esp32: Add board config to support MCP2515

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #2971:
URL: https://github.com/apache/incubator-nuttx/pull/2971#issuecomment-790672598


   Hi @Ouss4 I fixed the suggestion. He build succeed, only a MacOS failed and sometimes it does. Could you please merge it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis edited a comment on pull request #2971: esp32: Add board config to support MCP2515

Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #2971:
URL: https://github.com/apache/incubator-nuttx/pull/2971#issuecomment-790672598


   Hi @Ouss4 I implemented your suggestion. The build succeed, only a MacOS failed (but it happens sometimes). Could you please merge it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis edited a comment on pull request #2971: esp32: Add board config to support MCP2515

Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #2971:
URL: https://github.com/apache/incubator-nuttx/pull/2971#issuecomment-790672598


   Hi @Ouss4 I implemented your suggestion. The build succeed, only a MacOS failed and sometimes it does. Could you please merge it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2971: esp32: Add board config to support MCP2515

Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #2971:
URL: https://github.com/apache/incubator-nuttx/pull/2971#discussion_r586833257



##########
File path: boards/xtensa/esp32/esp32-devkitc/src/esp32_mcp2515.c
##########
@@ -0,0 +1,250 @@
+/****************************************************************************
+ * boards/xtensa/esp32/esp32devkitc/src/esp32_mcp2515.c

Review comment:
       you are right, it could become a common board logic, I will modify it!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org