You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2016/01/27 22:16:46 UTC
Review Request 42869: Fix stray printf style log replacement token
when logging triggered cron jobs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42869/
-----------------------------------------------------------
Review request for Aurora, John Sirois and Maxim Khutornenko.
Repository: aurora
Description
-------
Fix stray printf style log replacement token when logging triggered cron jobs.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 7d41a53d01206f06badda16e0149e8ad37dc5a69
Diff: https://reviews.apache.org/r/42869/diff/
Testing
-------
Thanks,
Joshua Cohen
Re: Review Request 42869: Fix stray printf style log replacement
token when logging triggered cron jobs.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42869/#review116631
-----------------------------------------------------------
Master (e2a973e) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 27, 2016, 9:16 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42869/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 9:16 p.m.)
>
>
> Review request for Aurora, John Sirois and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix stray printf style log replacement token when logging triggered cron jobs.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 7d41a53d01206f06badda16e0149e8ad37dc5a69
>
> Diff: https://reviews.apache.org/r/42869/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42869: Fix stray printf style log replacement
token when logging triggered cron jobs.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42869/#review116623
-----------------------------------------------------------
Ship it!
Ship It!
- John Sirois
On Jan. 27, 2016, 2:16 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42869/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 2:16 p.m.)
>
>
> Review request for Aurora, John Sirois and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix stray printf style log replacement token when logging triggered cron jobs.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 7d41a53d01206f06badda16e0149e8ad37dc5a69
>
> Diff: https://reviews.apache.org/r/42869/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42869: Fix stray printf style log replacement
token when logging triggered cron jobs.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42869/#review116632
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Jan. 27, 2016, 1:16 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42869/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 1:16 p.m.)
>
>
> Review request for Aurora, John Sirois and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix stray printf style log replacement token when logging triggered cron jobs.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 7d41a53d01206f06badda16e0149e8ad37dc5a69
>
> Diff: https://reviews.apache.org/r/42869/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joshua Cohen
>
>