You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/28 03:45:23 UTC
[GitHub] [flink] guoweiM opened a new pull request #13811: [FLINK-19836] Serialize the committable by the user provided serializer during network shuffle
guoweiM opened a new pull request #13811:
URL: https://github.com/apache/flink/pull/13811
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
The behavior of the committable's serializer that is extracted by the framework might be different with the serializer provided by the user. As a result the downstream operator might get a different committable if we use the serializer extracted by the framework during network shuffle. This leads to some unexpected result.
So this patch makes the shuffle between the `writer/committer/globalcommitter` use the serializer provided by the user.
## Brief change log
1. Change the intput/output type of writer operator from `CommT` to `byte[]`
2. Change the input/output type of committer operator from `CommT` to `byte[]`
3. Change the input/output type of global committer operator from `CommT` to `byte[]`
4. All the sink operator would not send any comittables if there is no downstream operator.
## Verifying this change
This change is already covered by existing tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13811: [FLINK-19836] Serialize the committable by the user provided serializer during network shuffle
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13811:
URL: https://github.com/apache/flink/pull/13811#issuecomment-718548036
Yes, let's close this once we know that #13825 works in the end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13811: [FLINK-19836] Serialize the committable by the user provided serializer during network shuffle
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13811:
URL: https://github.com/apache/flink/pull/13811#issuecomment-717677509
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1f87c59d4ccdac3e91b28aaefebde4cc0e479bdf (Wed Oct 28 03:47:48 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19836).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM closed pull request #13811: [FLINK-19836] Serialize the committable by the user provided serializer during network shuffle
Posted by GitBox <gi...@apache.org>.
guoweiM closed pull request #13811:
URL: https://github.com/apache/flink/pull/13811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13811: [FLINK-19836] Serialize the committable by the user provided serializer during network shuffle
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13811:
URL: https://github.com/apache/flink/pull/13811#issuecomment-717686306
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1f87c59d4ccdac3e91b28aaefebde4cc0e479bdf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8456",
"triggerID" : "1f87c59d4ccdac3e91b28aaefebde4cc0e479bdf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f87c59d4ccdac3e91b28aaefebde4cc0e479bdf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8456)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on pull request #13811: [FLINK-19836] Serialize the committable by the user provided serializer during network shuffle
Posted by GitBox <gi...@apache.org>.
guoweiM commented on pull request #13811:
URL: https://github.com/apache/flink/pull/13811#issuecomment-721475689
I think #13825 works. So I close this pull requests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13811: [FLINK-19836] Serialize the committable by the user provided serializer during network shuffle
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13811:
URL: https://github.com/apache/flink/pull/13811#issuecomment-717686306
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1f87c59d4ccdac3e91b28aaefebde4cc0e479bdf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1f87c59d4ccdac3e91b28aaefebde4cc0e479bdf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f87c59d4ccdac3e91b28aaefebde4cc0e479bdf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #13811: [FLINK-19836] Serialize the committable by the user provided serializer during network shuffle
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #13811:
URL: https://github.com/apache/flink/pull/13811#issuecomment-718528767
@guoweiM and @aljoscha what is the relationship of this PR with this one https://github.com/apache/flink/pull/13825 ? Shall this be closed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org