You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2023/02/24 22:23:08 UTC
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10328: Add Raw HLL and Raw Theta Aggregation support in Merge/Rollup
Jackie-Jiang commented on code in PR #10328:
URL: https://github.com/apache/pinot/pull/10328#discussion_r1117743096
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/ValueAggregatorFactory.java:
##########
@@ -40,6 +40,10 @@ public static ValueAggregator getValueAggregator(AggregationFunctionType aggrega
return new MaxValueAggregator(dataType);
case SUM:
return new SumValueAggregator(dataType);
+ case DISTINCTCOUNTRAWHLL:
Review Comment:
We can use the aggregator for both raw and non-raw function
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/DistinctCountRawThetaSketchAggregator.java:
##########
@@ -0,0 +1,43 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.segment.processing.aggregator;
+
+import org.apache.datasketches.theta.Sketch;
+import org.apache.datasketches.theta.Union;
+import org.apache.pinot.core.common.ObjectSerDeUtils;
+import org.apache.pinot.spi.utils.CommonConstants;
+
+
+public class DistinctCountRawThetaSketchAggregator implements ValueAggregator {
Review Comment:
Same here, suggest renaming it to `DistinctCountThetaSketchAggregator`
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/DistinctCountRawHLLAggregator.java:
##########
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.segment.processing.aggregator;
+
+import com.clearspring.analytics.stream.cardinality.CardinalityMergeException;
+import com.clearspring.analytics.stream.cardinality.HyperLogLog;
+import org.apache.pinot.core.common.ObjectSerDeUtils;
+
+
+public class DistinctCountRawHLLAggregator implements ValueAggregator {
Review Comment:
Suggest calling it `DistinctCountHLLAggregator` because it can be shared for both raw/non-raw function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org