You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "FMX (via GitHub)" <gi...@apache.org> on 2024/02/19 03:05:09 UTC
[PR] [CELEBORN-1255][FOLLOWUP] Fix MR UT [incubator-celeborn]
FMX opened a new pull request, #2302:
URL: https://github.com/apache/incubator-celeborn/pull/2302
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1255][FOLLOWUP] Fix MR UT [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2302:
URL: https://github.com/apache/incubator-celeborn/pull/2302#issuecomment-1951624429
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2302?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`3f5b1de`)](https://app.codecov.io/gh/apache/incubator-celeborn/commit/3f5b1de759ff0784c580029ff537a9e2057fdcf3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 48.94% compared to head [(`4018972`)](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2302?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.06%.
> :exclamation: Current head 4018972 differs from pull request most recent head f91490b. Consider uploading reports for the commit f91490b to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2302 +/- ##
==========================================
+ Coverage 48.94% 49.06% +0.13%
==========================================
Files 208 208
Lines 12893 12893
Branches 1113 1113
==========================================
+ Hits 6309 6325 +16
+ Misses 6176 6163 -13
+ Partials 408 405 -3
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2302?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1255][FOLLOWUP] Fix MR UT [incubator-celeborn]
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #2302:
URL: https://github.com/apache/incubator-celeborn/pull/2302#issuecomment-1951873971
> LGTM, thanks! Merging to main(v0.5.0)
the `branch-0.4` CI is also broken. @waitinfuture
https://github.com/apache/incubator-celeborn/actions/runs/7948486741/job/21698560139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1255][FOLLOWUP] Fix MR UT [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #2302:
URL: https://github.com/apache/incubator-celeborn/pull/2302#issuecomment-1953434659
> > LGTM, thanks! Merging to main(v0.5.0)
>
> the `branch-0.4` CI is also broken. @waitinfuture
>
> https://github.com/apache/incubator-celeborn/actions/runs/7948486741/job/21698560139
Cherrypicked https://github.com/apache/incubator-celeborn/commit/ac8b3035008dc775735185630aa01198bd4399bc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1255][FOLLOWUP] Fix MR UT [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #2302: [CELEBORN-1255][FOLLOWUP] Fix MR UT
URL: https://github.com/apache/incubator-celeborn/pull/2302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org