[GitHub] [incubator-datasketches-website] mkaszas commented on issue #91: Collapsed menus

[GitBox <gi...@apache.org>]

mkaszas commented on issue #91:
URL: https://github.com/apache/incubator-datasketches-website/issues/91#issuecomment-657199360


   @leerho Looks like there are 2 separate issues, but they are closely related:
   - `Background > The Challenge`, `Community > Downloads`, `Community > Community` and `Research > Research`
     There are links to these pages in the header of the page, and the script we execute on page load looks for the first link pointing to the current url and tries to highlight and expand it. This can be solved with using a more specific selector, so we only look for the link inside the TOC.
   
   - For the other links, the only issue I could reproduce was with pages that are referenced inside the TOC more than once. For example: `Sketch Families > Most Frequent > Frequent Distinct Sketches > Frequent Distinct Tuples Sketch`
     In these cases, the easiest solution would be to copy the contents of these pages to a new page, with a different path, so all of the links inside the TOC are unique.
   
   I can send in a PR for the first point tomorrow, let me know what you think about the second one.
   
   I couldn't see any issues with any of these pages though:
   ```
   Sketch Families / Most Frequent / Frequent Sketches Overview
   Sketch Families / Most Frequent / Frequent Item Sketches / Frequent Items Overview
   Sketch Families / Quantiles And Histograms / Quantiles Overview
   Sketch Families / Quantiles And Histograms / Quantiles Accuracy and Size
   Sketch Families / Quantiles And Histograms / Quantiles Examples / Quantiles Sketch Java Example
   Sketch Families / Quantiles And Histograms / Quantiles Studies / Definitions for Quantiles Studies
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org