You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Konrad Windszus <ko...@gmx.de> on 2017/04/05 09:56:56 UTC
Releasing test bundles
For ITs we sometimes leverage dedicated test bundles (which should only be deployed for the purpose of running the IT). Those test bundles are usually not released (i.e. stay at 1.0.0-SNAPSHOT). But with PaxExam or even with the slingstart-maven-plugin it is now easily possible to have ITs in the same Maven module as the actual bundle (e.g. https://github.com/apache/sling/tree/trunk/bundles/extensions/validation/core, leveraging PaxExam or https://github.com/apache/sling/tree/trunk/bundles/extensions/models/validation-impl leveraging slingstart-maven-plugin). For the former I have the problem that doing a release on that is not possible because that still has a dependency to https://github.com/apache/sling/blob/trunk/bundles/extensions/validation/test-services/pom.xml. What do you prefer:
1. Release with the Snapshot test dependency, leveraging http://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html#allowTimestampedSnapshots, compare with http://stackoverflow.com/questions/37562658/release-project-with-snapshot-test-dependency
or
2. Release the test-services as well?
Thanks for your input,
Konrad
Re: Releasing test bundles
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Wed, Apr 5, 2017 at 11:56 AM, Konrad Windszus <ko...@gmx.de> wrote:
> ...2. Release the test-services as well?..
+1, I've been doing this for a few modules already and I agree to make
it a general rule.
-Bertrand
Re: Releasing test bundles
Posted by Robert Munteanu <ro...@apache.org>.
On Wed, 2017-04-05 at 11:56 +0200, Konrad Windszus wrote:
> For ITs we sometimes leverage dedicated test bundles (which should
> only be deployed for the purpose of running the IT). Those test
> bundles are usually not released (i.e. stay at 1.0.0-SNAPSHOT). But
> with PaxExam or even with the slingstart-maven-plugin it is now
> easily possible to have ITs in the same Maven module as the actual
> bundle (e.g. https://github.com/apache/sling/tree/trunk/bundles/exten
> sions/validation/core, leveraging PaxExam or
> https://github.com/apache/sling/tree/trunk/bundles/extensions/models/
> validation-impl leveraging slingstart-maven-plugin). For the former I
> have the problem that doing a release on that is not possible because
> that still has a dependency to
> https://github.com/apache/sling/blob/trunk/bundles/extensions/validat
> ion/test-services/pom.xml. What do you prefer:
>
> 1. Release with the Snapshot test dependency, leveraging http://maven
> .apache.org/maven-release/maven-release-plugin/prepare-
> mojo.html#allowTimestampedSnapshots, compare with
> http://stackoverflow.com/questions/37562658/release-project-with-
> snapshot-test-dependency
> or�
> 2. Release the test-services as well?
I think this is better, as we can describe which version of the tests
is used to validate a certain release.
Since they would be included in the same release, there is no increase
in work for the release manager.
Robert
>
> Thanks for your input,
> Konrad
Re: Releasing test bundles
Posted by Robert Munteanu <ro...@apache.org>.
On Wed, 2017-04-05 at 13:12 +0200, Oliver Lietz wrote:
> On Wednesday 05 April 2017 11:56:56 Konrad Windszus wrote:
> > For ITs we sometimes leverage dedicated test bundles (which should
> > only be
> > deployed for the purpose of running the IT). Those test bundles are
> > usually
> > not released (i.e. stay at 1.0.0-SNAPSHOT). But with PaxExam or
> > even with
> > the slingstart-maven-plugin it is now easily possible to have ITs
> > in the
> > same Maven module as the actual bundle (e.g.
> > https://github.com/apache/sling/tree/trunk/bundles/extensions/valid
> > ation/co
> > re, leveraging PaxExam or
> > https://github.com/apache/sling/tree/trunk/bundles/extensions/model
> > s/valida
> > tion-impl leveraging slingstart-maven-plugin). For the former I
> > have the
> > problem that doing a release on that is not possible because that
> > still has
> > a dependency to
> > https://github.com/apache/sling/blob/trunk/bundles/extensions/valid
> > ation/te
> > st-services/pom.xml. What do you prefer:
> >
> > 1. Release with the Snapshot test dependency, leveraging
> > http://maven.apache.org/maven-release/maven-release-plugin/prepare-
> > mojo.htm
> > l#allowTimestampedSnapshots, compare with
> > http://stackoverflow.com/questions/37562658/release-project-with-sn
> > apshot-t
> > est-dependency or
> > 2. Release the test-services as well?
>
> 3. Move test services into bundle under test when possible (see
> Scripting�
> Thymeleaf for example)
+1 to that as well, I prefer it over 2. That being said, 2 is usually
much easier to do and in the context of a release I would not ask for
3.
Robert
>
> If 3. is not possible or to cumbersome, release test-services (2.).
>
> Regards,
> O.
>
> > Thanks for your input,
> > Konrad
>
>
Re: Releasing test bundles
Posted by Oliver Lietz <ap...@oliverlietz.de>.
On Wednesday 05 April 2017 11:56:56 Konrad Windszus wrote:
> For ITs we sometimes leverage dedicated test bundles (which should only be
> deployed for the purpose of running the IT). Those test bundles are usually
> not released (i.e. stay at 1.0.0-SNAPSHOT). But with PaxExam or even with
> the slingstart-maven-plugin it is now easily possible to have ITs in the
> same Maven module as the actual bundle (e.g.
> https://github.com/apache/sling/tree/trunk/bundles/extensions/validation/co
> re, leveraging PaxExam or
> https://github.com/apache/sling/tree/trunk/bundles/extensions/models/valida
> tion-impl leveraging slingstart-maven-plugin). For the former I have the
> problem that doing a release on that is not possible because that still has
> a dependency to
> https://github.com/apache/sling/blob/trunk/bundles/extensions/validation/te
> st-services/pom.xml. What do you prefer:
>
> 1. Release with the Snapshot test dependency, leveraging
> http://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.htm
> l#allowTimestampedSnapshots, compare with
> http://stackoverflow.com/questions/37562658/release-project-with-snapshot-t
> est-dependency or
> 2. Release the test-services as well?
3. Move test services into bundle under test when possible (see Scripting
Thymeleaf for example)
If 3. is not possible or to cumbersome, release test-services (2.).
Regards,
O.
> Thanks for your input,
> Konrad